From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/hiredis: fix install step for static build only
Date: Fri, 14 Apr 2017 22:30:09 +0200 [thread overview]
Message-ID: <20170414223009.78b495bc@free-electrons.com> (raw)
In-Reply-To: <20170414130225.16408-1-romain.naour@gmail.com>
Hello,
On Fri, 14 Apr 2017 15:02:25 +0200, Romain Naour wrote:
> The previous patch [1] didn't take into acount the static build only
> scenario. It try to install unconditionally a shared library.
>
> Handle the install step like for bzip2 package.
>
> Install the shared library only if BR2_SHARED_LIBS or
> BR2_SHARED_STATIC_LIBS is set and install the static library only
> if BR2_STATIC_LIBS or BR2_SHARED_STATIC_LIBS is set.
>
> [1] 96daacb720cffe1f83259462bef9d3da92925cd9
>
> Fixes:
> http://autobuild.buildroot.net/results/6be/6be8024dd664af83fcf49ede29c8ad59a37f73d1
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/hiredis/hiredis.mk | 29 +++++++++++++++++++++++------
> 1 file changed, 23 insertions(+), 6 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-14 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 13:02 [Buildroot] [PATCH] package/hiredis: fix install step for static build only Romain Naour
2017-04-14 20:30 ` Thomas Petazzoni [this message]
2017-04-24 19:29 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414223009.78b495bc@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox