From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] busybox: ncurses progs equiv as default
Date: Thu, 20 Apr 2017 07:00:19 +0300 [thread overview]
Message-ID: <20170420040019.bjfwlwaknjvrj33c@tarshish> (raw)
In-Reply-To: <1492654408-25342-1-git-send-email-matthew.weber@rockwellcollins.com>
Hi Matt,
On Wed, Apr 19, 2017 at 09:13:28PM -0500, Matt Weber wrote:
> By default, enable the busybox equivalents of the ncurses
> clear and reset if ncurses progs are not enabled.
Our default busybox.config enables these applets. If the user chooses to
disable them in a custom config, why should we force them back on?
baruch
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
> package/busybox/busybox.mk | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
> index 9d9fcc2..56ec939 100644
> --- a/package/busybox/busybox.mk
> +++ b/package/busybox/busybox.mk
> @@ -153,10 +153,15 @@ ifeq ($(BR2_PACKAGE_NCURSES_TARGET_PROGS),y)
> # /usr/bin/clear
> # /usr/bin/reset -> /usr/bin/tset (symlink)
> #
> -define BUSYBOX_DISABLE_NCURSES_PROGS
> +define BUSYBOX_NCURSES_PROGS
> $(call KCONFIG_DISABLE_OPT,CONFIG_CLEAR,$(BUSYBOX_BUILD_CONFIG))
> $(call KCONFIG_DISABLE_OPT,CONFIG_RESET,$(BUSYBOX_BUILD_CONFIG))
> endef
> +else
> +define BUSYBOX_NCURSES_PROGS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_CLEAR,$(BUSYBOX_BUILD_CONFIG))
> + $(call KCONFIG_ENABLE_OPT,CONFIG_RESET,$(BUSYBOX_BUILD_CONFIG))
> +endef
> endif
>
> define BUSYBOX_INSTALL_UDHCPC_SCRIPT
> @@ -240,7 +245,7 @@ define BUSYBOX_KCONFIG_FIXUP_CMDS
> $(BUSYBOX_SET_WATCHDOG)
> $(BUSYBOX_SET_SELINUX)
> $(BUSYBOX_MUSL_TWEAKS)
> - $(BUSYBOX_DISABLE_NCURSES_PROGS)
> + $(BUSYBOX_NCURSES_PROGS)
> endef
>
> define BUSYBOX_CONFIGURE_CMDS
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2017-04-20 4:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 2:13 [Buildroot] [PATCH 1/1] busybox: ncurses progs equiv as default Matt Weber
2017-04-20 4:00 ` Baruch Siach [this message]
2017-04-20 13:01 ` Matthew Weber
2017-04-23 21:32 ` Arnout Vandecappelle
2017-04-24 12:40 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420040019.bjfwlwaknjvrj33c@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox