From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 12/12] e2fsprogs: only add -lintl for static builds
Date: Sat, 22 Apr 2017 15:04:46 +0200 [thread overview]
Message-ID: <20170422150446.5596010b@free-electrons.com> (raw)
In-Reply-To: <20170422115955.22718-13-arnout@mind.be>
Hello,
On Sat, 22 Apr 2017 13:59:55 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
> index a60c69b395..84af7abab8 100644
> --- a/package/e2fsprogs/e2fsprogs.mk
> +++ b/package/e2fsprogs/e2fsprogs.mk
> @@ -77,17 +77,19 @@ HOST_E2FSPROGS_CONF_ENV += \
> ac_cv_header_magic_h=no \
> ac_cv_lib_magic_magic_file=no
>
> -ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
> +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE)$(BR2_STATIC_LIBS),yy)
> # util-linux libuuid pulls in libintl if needed, so ensure we also
> # link against it, otherwise static linking fails
> E2FSPROGS_CONF_ENV += LIBS=-lintl
> endif
>
> E2FSPROGS_MAKE_OPTS = LDCONFIG=true
> +
Unrelated change.
> E2FSPROGS_INSTALL_STAGING_OPTS = \
> DESTDIR=$(STAGING_DIR) \
> LDCONFIG=true \
> install-libs
> +
Ditto.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-04-22 13:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 11:59 [Buildroot] [PATCH v8 00/12] e2fsprogs: refactor to fix conflicts with busybox and util-linux Arnout Vandecappelle
2017-04-22 11:59 ` [Buildroot] [PATCH v8 01/12] e2fsprogs: change upstream URL sf.net -> sourceforge.net Arnout Vandecappelle
2017-04-22 12:28 ` Thomas Petazzoni
2017-04-22 11:59 ` [Buildroot] [PATCH v8 02/12] e2fsprogs: add missing arch depends to comment Arnout Vandecappelle
2017-04-22 12:28 ` Thomas Petazzoni
2017-04-22 11:59 ` [Buildroot] [PATCH v8 03/12] e2fsprogs: change into menuconfig Arnout Vandecappelle
2017-04-22 12:28 ` Thomas Petazzoni
2017-04-22 11:59 ` [Buildroot] [PATCH v8 04/12] e2fsprogs: remove uuidgen support Arnout Vandecappelle
2017-04-22 12:29 ` Thomas Petazzoni
2017-04-22 21:57 ` Arnout Vandecappelle
2017-04-22 11:59 ` [Buildroot] [PATCH v8 05/12] e2fsprogs: use libblkid and libuuid from util-linux for host Arnout Vandecappelle
2017-04-22 12:30 ` Thomas Petazzoni
2017-04-22 11:59 ` [Buildroot] [PATCH v8 06/12] e2fsprogs: let it create symlinks Arnout Vandecappelle
2017-04-22 12:49 ` Thomas Petazzoni
2017-04-22 22:32 ` Arnout Vandecappelle
2017-04-22 11:59 ` [Buildroot] [PATCH v8 07/12] e2fsprogs: refactor to fix conflicts with busybox and util-linux Arnout Vandecappelle
2017-04-22 13:03 ` Thomas Petazzoni
2017-04-22 22:34 ` Arnout Vandecappelle
2017-04-22 11:59 ` [Buildroot] [PATCH v8 08/12] e2fsprogs: add help text for all config options Arnout Vandecappelle
2017-04-22 11:59 ` [Buildroot] [PATCH v8 09/12] e2fsprogs: disable unneeded features for host Arnout Vandecappelle
2017-04-22 13:03 ` Thomas Petazzoni
2017-04-22 22:34 ` Arnout Vandecappelle
2017-04-22 11:59 ` [Buildroot] [PATCH v8 10/12] e2fsprogs: add explicit --enable/--disable configure options Arnout Vandecappelle
2017-04-22 11:59 ` [Buildroot] [PATCH v8 11/12] e2fsprogs: avoid conflict with util-linux fsck wrapper Arnout Vandecappelle
2017-04-22 11:59 ` [Buildroot] [PATCH v8 12/12] e2fsprogs: only add -lintl for static builds Arnout Vandecappelle
2017-04-22 13:04 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170422150446.5596010b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox