From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/7] package configs: clean up indentation warnings.
Date: Sat, 22 Apr 2017 15:53:52 +0200 [thread overview]
Message-ID: <20170422155352.7c6cca5a@free-electrons.com> (raw)
In-Reply-To: <20170421152452.11236-1-aduskett@codeblue.com>
Hello,
On Fri, 21 Apr 2017 11:24:46 -0400, Adam Duskett wrote:
> The check-package script when ran gave warnings on indentation issues
> on all of these Config files. This patch cleans up all warnings
> related to the indentation of the Config files in the package directory.
>
> Signed-off-by: Adam Duskett <aduskett@codeblue.com>
> ---
> package/b43-firmware/Config.in | 8 +-
> package/binutils/Config.in.host | 12 +-
> package/gcc/Config.in.host | 156 +++++------
> package/gdb/Config.in.host | 12 +-
> package/jquery-ui-themes/Config.in | 96 +++----
> package/kodi/Config.in | 100 +++----
> package/linux-headers/Config.in.host | 85 +++---
> package/lua/Config.in | 12 +-
> package/uclibc/Config.in | 28 +-
> package/x11r7/Config.in | 526 ++++++++++++++++++-----------------
> 10 files changed, 522 insertions(+), 513 deletions(-)
This looks good overall, except for package/Config.in. The indentation
is done on purpose in this file, I believe so that "diff" puts some
useful text in the context, making the patches touching
package/Config.in easier to read.
So please drop the change to package/Config.in.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-22 13:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 15:24 [Buildroot] [PATCH 1/7] package configs: clean up indentation warnings Adam Duskett
2017-04-21 15:24 ` [Buildroot] [PATCH 2/7] package configs: clean up ordering Adam Duskett
2017-04-22 13:56 ` Thomas Petazzoni
2017-04-22 17:23 ` Adam Duskett
2017-04-21 15:24 ` [Buildroot] [PATCH 3/7] package makefiles: clean up backslash spacing Adam Duskett
2017-04-22 13:59 ` Thomas Petazzoni
2017-04-21 15:24 ` [Buildroot] [PATCH 4/7] busybox.mk: fix unexpected indent with tabs Adam Duskett
2017-04-22 13:51 ` Thomas Petazzoni
2017-04-21 15:24 ` [Buildroot] [PATCH 5/7] xenomai.mk: fix expected " Adam Duskett
2017-04-22 13:52 ` Thomas Petazzoni
2017-04-21 15:24 ` [Buildroot] [PATCH 6/7] qt5.mk: add header Adam Duskett
2017-04-22 13:52 ` Thomas Petazzoni
2017-04-21 15:24 ` [Buildroot] [PATCH 7/7] qt.mk: fix header Adam Duskett
2017-04-22 13:52 ` Thomas Petazzoni
2017-04-22 13:53 ` Thomas Petazzoni [this message]
2017-04-22 16:47 ` [Buildroot] [PATCH 1/7] package configs: clean up indentation warnings Adam Duskett
2017-04-22 22:09 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170422155352.7c6cca5a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox