From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] ne10: Add aarch64 configuration option
Date: Sat, 29 Apr 2017 14:09:53 +0200 [thread overview]
Message-ID: <20170429140953.0b7badef@free-electrons.com> (raw)
In-Reply-To: <1493418486-109149-2-git-send-email-g4@novadsp.com>
Hello,
On Fri, 28 Apr 2017 23:28:06 +0100, J Evans wrote:
> +ifeq ($(BR2_aarch64),y)
> +NE10_CONF_OPTS += \
> + -DNE10_LINUX_TARGET_ARCH=aarch64
> +endif
PATCH 1/2 is already enabling ne10 on AArch64, so there's something
wrong going on here. This change should go with the patch enabling ne10
on AArch64.
But I believe you should in fact rework your patches:
- One patch that just bumps ne10, keeping only the ARM support
- One patch that refactors the architecture dependency with a
Config.in hidden boolean BR2_PACKAGE_NE10_ARCH_SUPPORTS
- One patch that allows to use ne10 on AArch64
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-29 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 22:28 [Buildroot] [PATCH 1/2] ne10: bump to version 1.2.1. Remove obsolete patch file for modifying thumb code generation J Evans
2017-04-28 22:28 ` [Buildroot] [PATCH 2/2] ne10: Add aarch64 configuration option J Evans
2017-04-29 12:00 ` g4 at novadsp.com
2017-04-29 12:09 ` Thomas Petazzoni [this message]
2017-04-29 12:43 ` jerry at chordia.co.uk
2017-04-29 12:08 ` [Buildroot] [PATCH 1/2] ne10: bump to version 1.2.1. Remove obsolete patch file for modifying thumb code generation Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170429140953.0b7badef@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox