Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 04/25] fix ordering on configs starting with 'c'
Date: Sat, 29 Apr 2017 21:14:09 +0200	[thread overview]
Message-ID: <20170429211409.51461a47@free-electrons.com> (raw)
In-Reply-To: <20170422171811.1346-4-Adamduskett@outlook.com>

Hello,

On Sat, 22 Apr 2017 13:17:50 -0400, Adam Duskett wrote:

> diff --git a/package/cdrkit/Config.in b/package/cdrkit/Config.in
> index af18ba9..c5f43f2 100644
> --- a/package/cdrkit/Config.in
> +++ b/package/cdrkit/Config.in
> @@ -1,10 +1,10 @@
>  config BR2_PACKAGE_CDRKIT
> +	bool "cdrkit"
>  	# Needed for libbz
> +	depends on BR2_USE_MMU # fork
>  	select BR2_PACKAGE_BZIP2
>  	select BR2_PACKAGE_LIBCAP
>  	select BR2_PACKAGE_ZLIB
> -	depends on BR2_USE_MMU # fork
> -	bool "cdrkit"

Good example of change that introduce something not completely correct:
the "Needed for libbz" comment is no longer at the right place. I've
moved it to the right location.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-04-29 19:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-22 17:17 [Buildroot] [PATCH v2 01/25] package configs: clean up indentation warnings Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 02/25] fix ordering on configs starting with 'a' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 03/25] fix ordering on configs starting with 'b' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 04/25] fix ordering on configs starting with 'c' Adam Duskett
2017-04-29 19:14   ` Thomas Petazzoni [this message]
2017-04-22 17:17 ` [Buildroot] [PATCH v2 05/25] fix ordering on configs starting with 'd' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 06/25] fix ordering on configs starting with 'e' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 07/25] fix ordering on configs starting with 'f' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 08/25] fix ordering on configs starting with 'g' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 09/25] fix ordering on configs starting with 'i' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 10/25] fix ordering on configs starting with 'j' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 11/25] fix ordering on configs starting with 'k' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 12/25] fix ordering on configs starting with 'l' Adam Duskett
2017-04-22 17:17 ` [Buildroot] [PATCH v2 13/25] fix ordering on configs starting with 'm' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 14/25] fix ordering on configs starting with 'n' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 15/25] fix ordering on configs starting with 'o' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 16/25] fix ordering on configs starting with 'p' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 17/25] fix ordering on configs starting with 'q' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 18/25] fix ordering on configs starting with 'r' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 19/25] fix ordering on configs starting with 's' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 20/25] fix ordering on configs starting with 't' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 21/25] fix ordering on configs starting with 'u' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 22/25] fix ordering on configs starting with 'v' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 23/25] fix ordering on configs starting with 'w' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 24/25] fix ordering on configs starting with 'x' Adam Duskett
2017-04-22 17:18 ` [Buildroot] [PATCH v2 25/25] fix ordering on configs starting with 'y' Adam Duskett
2017-04-29 15:15 ` [Buildroot] [PATCH v2 01/25] package configs: clean up indentation warnings Thomas Petazzoni
2017-05-02 20:34 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170429211409.51461a47@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox