From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/expedite: fix build issue with gcc < 5
Date: Sun, 30 Apr 2017 23:02:35 +0200 [thread overview]
Message-ID: <20170430230235.70b7ffc5@free-electrons.com> (raw)
In-Reply-To: <20170430102528.11476-1-romain.naour@gmail.com>
Hello,
On Sun, 30 Apr 2017 12:25:28 +0200, Romain Naour wrote:
> The code use for loop initial declarations which are only allowed in
> C99 mode which is not the default C standard with gcc < 5.
>
> This way of writing for loop was added by the latest commit and it is
> not consistent with the rest of the code.
> So revert to the C89 for loop syntax.
>
> Reported upstream:
> https://phab.enlightenment.org/T5440
>
> Fixes:
> http://autobuild.buildroot.net/results/ed8/ed840755e8e486e48eab8c13a8bb5e9a448199ce
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> .../0001-fix-build-failure-with-gcc-5.patch | 289 +++++++++++++++++++++
> 1 file changed, 289 insertions(+)
> create mode 100644 package/expedite/0001-fix-build-failure-with-gcc-5.patch
I'm not sure why you gave up on the -std=c99 solution, but OK, I've
applied this patch. We'll see what upstream suggests.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-04-30 21:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 10:25 [Buildroot] [PATCH v2] package/expedite: fix build issue with gcc < 5 Romain Naour
2017-04-30 21:02 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170430230235.70b7ffc5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox