From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [Patch v5 1/7] pkg-virtual: fix host dependencies handling
Date: Mon, 1 May 2017 10:58:22 +0200 [thread overview]
Message-ID: <20170501085822.GC3118@scaer> (raw)
In-Reply-To: <20170422173840.19694-2-eric.le.bihan.dev@free.fr>
Eric, All,
On 2017-04-22 19:38 +0200, Eric Le Bihan spake thusly:
> If $(BR2_PACKAGE_HAS_HOST_FOO) is defined, then the pkg-virtual
> infrastructure will check if $(BR2_PACKAGE_PROVIDES_HOST_FOO) is not
> empty.
>
> But later, $(BR2_PACKAGE_HOST_FOO_DEPENDENCIES) will be set from
> $(BR2_PACKAGE_PROVIDES_FOO), ignoring $(BR2_PACKAGE_PROVIDES_HOST_FOO).
>
> So fix this discrepancy by setting $(BR2_PACKAGE_HOST_FOO_DEPENDENCIES)
> from $(BR2_PACKAGE_PROVIDES_FOO) only if $(BR2_PACKAGE_PROVIDES_HOST_FOO)
> is empty.
>
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/pkg-virtual.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/pkg-virtual.mk b/package/pkg-virtual.mk
> index 2e83e07..b8878ad 100644
> --- a/package/pkg-virtual.mk
> +++ b/package/pkg-virtual.mk
> @@ -49,7 +49,11 @@ $(2)_IS_VIRTUAL = YES
> ifeq ($(4),target)
> $(2)_DEPENDENCIES += $$(call qstrip,$$(BR2_PACKAGE_PROVIDES_$(2)))
> else
> +ifeq ($$(call qstrip,$$(BR2_PACKAGE_PROVIDES_$(2))),)
> $(2)_DEPENDENCIES += host-$$(call qstrip,$$(BR2_PACKAGE_PROVIDES_$(3)))
> +else
> +$(2)_DEPENDENCIES += $$(call qstrip,$$(BR2_PACKAGE_PROVIDES_$(2)))
> +endif
> endif
>
> # Call the generic package infrastructure to generate the necessary
> --
> 2.9.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-05-01 8:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 17:38 [Buildroot] [Patch v5 0/7] Add support for the Rust programming language Eric Le Bihan
2017-04-22 17:38 ` [Buildroot] [Patch v5 1/7] pkg-virtual: fix host dependencies handling Eric Le Bihan
2017-05-01 8:58 ` Yann E. MORIN [this message]
2017-04-22 17:38 ` [Buildroot] [Patch v5 2/7] rustc: new virtual package Eric Le Bihan
2017-04-22 17:38 ` [Buildroot] [Patch v5 3/7] rust-bin: new package Eric Le Bihan
2017-04-22 17:38 ` [Buildroot] [Patch v5 4/7] rustc: expose host variant in menuconfig Eric Le Bihan
2017-04-22 17:38 ` [Buildroot] [Patch v5 5/7] rust-bootstrap: new package Eric Le Bihan
2017-04-22 17:38 ` [Buildroot] [Patch v5 6/7] cargo-bootstrap: " Eric Le Bihan
2017-04-22 17:38 ` [Buildroot] [Patch v5 7/7] rust: " Eric Le Bihan
2017-04-24 18:27 ` [Buildroot] [Patch v5 0/7] Add support for the Rust programming language Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501085822.GC3118@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox