From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libcsv: new package
Date: Mon, 1 May 2017 21:27:07 +0200 [thread overview]
Message-ID: <20170501212707.2729be64@free-electrons.com> (raw)
In-Reply-To: <1493660240-45710-1-git-send-email-matthew.weber@rockwellcollins.com>
Hello,
Thanks for this contribution, see some comments below.
On Mon, 1 May 2017 12:37:20 -0500, Matt Weber wrote:
> package/Config.in | 1 +
> package/libcsv/Config.in | 10 ++++++++++
> package/libcsv/libcsv.hash | 2 ++
> package/libcsv/libcsv.mk | 15 +++++++++++++++
Please add an entry to the DEVELOPERS file.
> +LIBCSV_VERSION = 3.0.3
> +LIBCSV_SITE = http://sourceforge.net/projects/libcsv/files
> +LIBCSV_SOURCE = libcsv-$(LIBCSV_VERSION).tar.gz
Not needed, this is the default value.
> +LIBCSV_LICENSE = LGPLv2.1+
Please use the SPDX license code: LGPL-2.1+
> +LIBCSV_LICENSE_FILES = COPYING.LESSER
> +LIBCSV_INSTALL_STAGING = YES
> +
> +$(eval $(host-autotools-package))
Why are you adding a host package ? If you don't intend to use it as a
dependency for another package or don't have a good reason to have a
host package, please don't add a host variant.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-01 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 17:37 [Buildroot] [PATCH 1/1] libcsv: new package Matt Weber
2017-05-01 19:27 ` Thomas Petazzoni [this message]
2017-05-01 19:29 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501212707.2729be64@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox