From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS
Date: Wed, 3 May 2017 16:22:44 +0200 [thread overview]
Message-ID: <20170503162244.5b67294e@free-electrons.com> (raw)
In-Reply-To: <f7abac9c0ca017bffd3109f7df0d6bfa7f099281.1493815595.git.baruch@tkos.co.il>
Hello,
On Wed, 3 May 2017 15:46:35 +0300, Baruch Siach wrote:
> This allows a static build of picocom when BR2_STATIC_LIBS=y but the toolchain
> provides static and shared libraries.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/picocom/picocom.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/picocom/picocom.mk b/package/picocom/picocom.mk
> index 07bda0e745cd..4e25556f4c55 100644
> --- a/package/picocom/picocom.mk
> +++ b/package/picocom/picocom.mk
> @@ -10,7 +10,8 @@ PICOCOM_LICENSE = GPL-2.0+
> PICOCOM_LICENSE_FILES = LICENSE.txt
>
> define PICOCOM_BUILD_CMDS
> - $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
> + $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
> + LDFLAGS="$(TARGET_LDFLAGS)" -C $(@D)
We already pass LDFLAGS in $(TARGET_CONFIGURE_OPTS). Should we pass
$(TARGET_CONFIGURE_OPTS) on the right hand side of $(MAKE) ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-03 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 12:46 [Buildroot] [PATCH 1/2] picocom: bump to version 2.2 Baruch Siach
2017-05-03 12:46 ` [Buildroot] [PATCH 2/2] picocom: force target LDFLAGS Baruch Siach
2017-05-03 14:22 ` Thomas Petazzoni [this message]
2017-05-03 14:28 ` Baruch Siach
2017-05-03 15:25 ` Peter Korsgaard
2017-05-03 17:00 ` Baruch Siach
2017-05-03 19:29 ` Peter Korsgaard
2017-05-05 19:35 ` Peter Korsgaard
2017-05-03 15:24 ` [Buildroot] [PATCH 1/2] picocom: bump to version 2.2 Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503162244.5b67294e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox