From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/kodi-skin-confluence: new package
Date: Thu, 4 May 2017 21:10:37 +0200 [thread overview]
Message-ID: <20170504211037.54389e3d@free-electrons.com> (raw)
In-Reply-To: <20170429203608.17700-1-bernd.kuhls@t-online.de>
Hello,
On Sat, 29 Apr 2017 22:36:07 +0200, Bernd Kuhls wrote:
> +KODI_SKIN_CONFLUENCE_VERSION = 7044dabb3a818d7ff47b7a34bfb3480f2a9441d9
> +KODI_SKIN_CONFLUENCE_SITE = $(call github,xbmc,skin.confluence,$(KODI_SKIN_CONFLUENCE_VERSION))
> +KODI_SKIN_CONFLUENCE_LICENSE = GPLv2+
You should use SPDX license codes, and GPLv2+ is not a valid SPDX
license code.
In addition, I didn't see anything in the source code that says "or
later". So I've changed this to GPL-2.0.
> +KODI_SKIN_CONFLUENCE_LICENSE_FILES = LICENSE.txt
> +KODI_SKIN_CONFLUENCE_DEPENDENCIES = kodi
> +KODI_SKIN_CONFLUENCE_CONF_OPTS = -DOVERRIDE_PATHS=1
This is not used anywhere in your package... it's a generic-package.
Applied with those issues fixed.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-05-04 19:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 20:36 [Buildroot] [PATCH v2 1/2] package/kodi-skin-confluence: new package Bernd Kuhls
2017-04-29 20:36 ` [Buildroot] [PATCH v2 2/2] package/kodi: add Kconfig options to remove default skins Bernd Kuhls
2017-05-01 8:09 ` Yann E. MORIN
2018-03-31 12:45 ` Arnout Vandecappelle
2017-05-01 7:46 ` [Buildroot] [PATCH v2 1/2] package/kodi-skin-confluence: new package Yann E. MORIN
2017-05-07 12:08 ` Bernd Kuhls
2017-05-04 19:10 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504211037.54389e3d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox