[Buildroot] [PATCH 1/1] libqmi: musl compat canonicalize_file_name

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Mon,  1 May 2017 20:29:06 -0500, Matt Weber wrote:

> ++#ifndef HAVE_CANONICALIZE_FILE_NAME
> ++#include <limits.h>
> ++#include <string.h>
> ++#include <stdlib.h>
> ++#include <stdio.h>
> ++static char * canonicalize_file_name(const char *path)
> ++{
> ++       char buf[PATH_MAX] = { };
> ++
> ++       snprintf(buf, sizeof(buf) - 1, "%s", path);
> ++
> ++       if (!realpath(path, buf))
> ++               return NULL;
> ++
> ++       return strdup(buf);
> ++}
> ++#endif

This has been insufficiently tested: while it fixes the build with
musl, it breaks the build with glibc and uclibc. Indeed, those C
libraries already provide canonicalize_file_name(), causing a
redefinition error.

You forgot to add an AC_CHECK_FUNCS() check in configure.ac. I've
committed a fix that adds it.

Please try to test more carefully the fixes.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com