Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 02/10] package/python-traitlets: New package
Date: Thu, 4 May 2017 21:57:29 +0200	[thread overview]
Message-ID: <20170504215729.7c270248@free-electrons.com> (raw)
In-Reply-To: <20170427213340.26917-3-andrew.smirnov@gmail.com>

Hello,

On Thu, 27 Apr 2017 14:33:32 -0700, Andrey Smirnov wrote:

> +config BR2_PACKAGE_PYTHON_TRAITLETS
> +	bool "python-traitlets"
> +	select BR2_PACKAGE_PYTHON_DECORATOR
> +	select BR2_PACKAGE_PYTHON_ENUM if BR2_PACKAGE_PYTHON

Are you sure?

According to https://pypi.python.org/pypi/traitlets/json:

        "requires_dist": [
            "mock; python_version==\"2.7\" and extra == 'test'", 
            "pytest; extra == 'test'", 
            "enum34; python_version==\"3.3\"", 
            "enum34; python_version==\"2.7\"", 
            "six", 
            "ipython-genutils", 
            "decorator"
        ], 

So it needs python-enum34, not python-enum it seems. It also needs
ipython-genutils apparently.

Generally, make sure that if you enable *ONLY* this package, and do a
build, you can "import traitlets" without error on the target.

> diff --git a/package/python-traitlets/python-traitlets.hash b/package/python-traitlets/python-traitlets.hash
> new file mode 100644
> index 0000000..3b14991
> --- /dev/null
> +++ b/package/python-traitlets/python-traitlets.hash
> @@ -0,0 +1,2 @@
> +# sha256 locally computed
> +sha256 370f938ad730d52272ef74f96f831cb21138f6168e46fe582fe256c35cc656ce python-traitlets-4.3.2.tar.gz

Please also add md5 from https://pypi.python.org/pypi/traitlets/json.

> diff --git a/package/python-traitlets/python-traitlets.mk b/package/python-traitlets/python-traitlets.mk
> new file mode 100644
> index 0000000..45f393d
> --- /dev/null
> +++ b/package/python-traitlets/python-traitlets.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# python-traitlets
> +#
> +################################################################################
> +
> +PYTHON_TRAITLETS_VERSION = 4.3.2
> +PYTHON_TRAITLETS_SOURCE = python-traitlets-$(PYTHON_TRAITLETS_VERSION).tar.gz
> +PYTHON_TRAITLETS_SITE = $(call github,ipython,traitlets,$(PYTHON_TRAITLETS_VERSION))

Please use the tarball from https://pypi.python.org/pypi/traitlets/json.

And add an entry to the DEVELOPERS file.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-05-04 19:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 21:33 [Buildroot] [PATCH v2 00/10] Update IPython's dependencies Andrey Smirnov
2017-04-27 21:33 ` [Buildroot] [PATCH v2 01/10] package/python-decorator: New package Andrey Smirnov
2017-05-04 19:49   ` Thomas Petazzoni
2017-04-27 21:33 ` [Buildroot] [PATCH v2 02/10] package/python-traitlets: " Andrey Smirnov
2017-05-04 19:57   ` Thomas Petazzoni [this message]
2017-04-27 21:33 ` [Buildroot] [PATCH v2 03/10] package/python-simplegeneric: " Andrey Smirnov
2017-05-04 20:11   ` Thomas Petazzoni
2017-04-27 21:33 ` [Buildroot] [PATCH v2 04/10] package/python-ipython-genutils: " Andrey Smirnov
2017-04-27 21:33 ` [Buildroot] [PATCH v2 05/10] package/python-scandir: " Andrey Smirnov
2017-05-04 20:18   ` Thomas Petazzoni
2017-05-04 20:27     ` Andrey Smirnov
2017-04-27 21:33 ` [Buildroot] [PATCH v2 06/10] package/python-pathlib2: " Andrey Smirnov
2017-04-27 21:33 ` [Buildroot] [PATCH v2 07/10] package/python-pickleshare: " Andrey Smirnov
2017-04-27 21:33 ` [Buildroot] [PATCH v2 08/10] package/python-backports-shutil-get-terminal-size: " Andrey Smirnov
2017-04-27 21:33 ` [Buildroot] [PATCH v2 09/10] package/python-ipython: Reformat help text to avoid warnings Andrey Smirnov
2017-05-04 20:19   ` Thomas Petazzoni
2017-04-27 21:33 ` [Buildroot] [PATCH v2 10/10] package/python-ipython: Add dependecy list Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504215729.7c270248@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox