[Buildroot] [PATCH v2 1/1] package/cwiid: add optional dependency to bluez5_utils

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Tue, 21 Mar 2017 09:36:23 +0100, Arnout Vandecappelle wrote:

> >> -	select BR2_PACKAGE_BLUEZ_UTILS
> >> +	select BR2_PACKAGE_BLUEZ5_UTILS if !BR2_PACKAGE_BLUEZ_UTILS  
> > 
> > You need to add missing bluez5_utils dependencies 
> > (BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4, BR2_TOOLCHAIN_HAS_SYNC_4). Changing 
> > bluez_utils to bluez5_utils in the comments above would also be nice.  
> 
>  Darn, this is getting complicated... We would want to keep the dependencies as
> they are, and use bluez_utils in case bluez5_utils are not available. But that
> would mean something like:
> 
> 	select BR2_PACKAGE_BLUEZ5_UTILS if !BR2_PACKAGE_BLUEZ_UTILS \
> 		&& BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4 \
> 		&& BR2_TOOLCHAIN_HAS_SYNC_4
> 	select BR2_PACKAGE_BLUEZ_UTILS if !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4 \
> 		|| !BR2_TOOLCHAIN_HAS_SYNC_4
> 
>  Yuk...
> 
>  Perhaps a BR2_PACKAGE_BLUEZ5_UTILS_ARCH_SUPPORTS would help?

Perhaps it's a case where we need to use a "depends on" dependency
rather than a "select" dependency, i.e do:

	depends on BR2_PACKAGE_BLUEZ5_UTILS || BR2_PACKAGE_BLUEZ_UTILS

Bernd, could you resubmit your patch with this idea? Don't forget to
remove the "depends on" on toolchain/architecture features that are no
longer needed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com