From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] rhash: new package
Date: Mon, 8 May 2017 23:16:03 +0200 [thread overview]
Message-ID: <20170508211603.GB3544@scaer> (raw)
In-Reply-To: <20170508173456.fep2syi43cvqs7ul@tarshish>
Vicente, Baruch, All,
On 2017-05-08 20:34 +0300, Baruch Siach spake thusly:
> Hi Vicente,
>
> On Mon, May 08, 2017 at 06:00:06PM +0100, Vicente Olivert Riera wrote:
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > ---
> > Changes v2 -> v3:
> > - Nothing
> > Changes v1 -> v2:
> > - rename package to rhash
> > - take the help text of the library instead of the console utility
> > - sub-config option for the rhash binary starts with the package name
> > - conditionals for shared/static/shared-static reordered
> > - put make options into a make_opts variable
> > - install the console utility to staging as well
> > (All suggestions by Arnout)
>
> [...]
>
> > +ifeq ($(BR2_PACKAGE_RHASH_BIN),y)
> > +define RHASH_INSTALL_RHASH_BIN
> > + $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> > + DESTDIR="$(STAGING_DIR)" $(RHASH_MAKE_OPTS) install-shared
>
> You mention above that Arnout suggested to install the binaries to staging.
> But this is quite unusual. A comment explaining the reason for that would be
> nice.
And please do so in a post-staging-install hook, not in the post-target-install
hook.
Regards,
Yann E. MORIN.
> > + $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> > + DESTDIR="$(TARGET_DIR)" $(RHASH_MAKE_OPTS) install-shared
> > +endef
> > +RHASH_POST_INSTALL_TARGET_HOOKS += RHASH_INSTALL_RHASH_BIN
> > +endif
> > +
> > +$(eval $(generic-package))
>
> baruch
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2017-05-08 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 17:00 [Buildroot] [PATCH v3 1/2] rhash: new package Vicente Olivert Riera
2017-05-08 17:00 ` [Buildroot] [PATCH v3 2/2] cmake: bump version to 3.8.1 Vicente Olivert Riera
2017-05-08 17:34 ` [Buildroot] [PATCH v3 1/2] rhash: new package Baruch Siach
2017-05-08 21:16 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508211603.GB3544@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox