From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libloki: new package
Date: Thu, 11 May 2017 22:33:07 +0200 [thread overview]
Message-ID: <20170511223307.157be03a@free-electrons.com> (raw)
In-Reply-To: <20170506140707.12931-1-romain.naour@gmail.com>
Hello,
On Sat, 6 May 2017 16:07:07 +0200, Romain Naour wrote:
> +# install to TARGET_DIR only the shared library
> +ifeq ($(BR2_STATIC_LIBS),)
> +define LIBLOKI_INSTALL_STAGING_SHARED_LIB
> + $(MAKE) -C $(@D)/src DESTDIR=$(TARGET_DIR) $(LIBLOKI_INSTALL_TARGETS)
> +endef
> +endif
> +
> +define LIBLOKI_INSTALL_TARGET_CMDS
> + $(LIBLOKI_INSTALL_STAGING_SHARED_LIB)
> +endef
This was a bit unnecessarily complicated, calling:
$(MAKE) -C $(@D)/src DESTDIR=$(TARGET_DIR) $(LIBLOKI_INSTALL_TARGETS)
unconditionally is just fine. Yes for static libraries, it means they
will be installed in $(TARGET_DIR), but they are anyway removed in the
target-finalize step. So in such situations, I do prefer to keep a
simple .mk file.
Committed to next with this fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-11 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 14:07 [Buildroot] [PATCH] package/libloki: new package Romain Naour
2017-05-11 20:33 ` Thomas Petazzoni [this message]
[not found] <1493758169-18291-1-git-send-email-corentin.guillevic@smile.fr>
2017-05-02 21:50 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511223307.157be03a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox