From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/opencv3: fix build for x86_64 target
Date: Fri, 12 May 2017 12:27:23 +0200 [thread overview]
Message-ID: <20170512122723.48912a90@free-electrons.com> (raw)
In-Reply-To: <20170512112054.447fb67a@free-electrons.com>
Hello,
On Fri, 12 May 2017 11:20:54 +0200, Thomas Petazzoni wrote:
> On Thu, 4 May 2017 23:53:33 +0200, Samuel Martin wrote:
> > This change backports a fix from upstream fixing missing symbols due to
> > wrong compiler optimization flags.
> >
> > On Buildroot side, also remove deprecated options passed on the
> > configure command.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/af9/af950c6172a578c4eeeb9440b6990ceb48263fa6/build-end.log
> > http://autobuild.buildroot.net/results/e88/e8832302cd4f30cec076f67965f6aacbaca5b955/build-end.log
> >
> > Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> > ---
> > .../0001-cmake-support-multiple-CPU-targets.patch | 2501 ++++++++++++++++++++
> > package/opencv3/opencv3.mk | 16 +-
> > 2 files changed, 2502 insertions(+), 15 deletions(-)
> > create mode 100644 package/opencv3/0001-cmake-support-multiple-CPU-targets.patch
>
> This patch does more harm than good: it breaks a lot of configurations.
> See http://autobuild.buildroot.net/?reason=opencv3-3.2.0.
>
> I'll revert later today unless a better fix is proposed.
I have found and fixed the problem: your patch contains a file rename,
and patch < 2.7 don't support file renames. So I've re-generated the
patch without file renames (git format-patch --no-renames). I verified
that it indeed fixes the problem on build machines with patch < 2.7.
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-05-12 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 21:53 [Buildroot] [PATCH] package/opencv3: fix build for x86_64 target Samuel Martin
2017-05-11 20:51 ` Thomas Petazzoni
2017-05-12 9:20 ` Thomas Petazzoni
2017-05-12 10:27 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512122723.48912a90@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox