From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] radvd: fix build with 4.11 kernel headers
Date: Sat, 13 May 2017 15:14:30 +0200 [thread overview]
Message-ID: <20170513151430.19c863d9@free-electrons.com> (raw)
In-Reply-To: <1494488270-10121-1-git-send-email-thomas.petazzoni@free-electrons.com>
Hello,
On Thu, 11 May 2017 09:37:50 +0200, Thomas Petazzoni wrote:
> Since the introduction of 4.11 kernel headers in Buildroot, radvd has
> failed to build with all toolchains using this kernel header version.
>
> The issue comes from the fact that radvd includes both <net/if_arp.h>
> and <linux/if_arp.h> if they are available. Until 4.11,
> <linux/if_arp.h> was in fact not included, because the
> AC_CHECK_HEADERS() test concluded this header was unsuitable. This has
> been fixed in the upstream kernel by commit
> 2618be7dccf8739b89e1906b64bd8d551af351e6 ("uapi: fix linux/if.h
> userspace compilation errors"). So now, the radvd configure script
> considers both <net/if_arp.h> and <linux/if_arp.h> as suitable
> headers, and includes both of them, leading to the duplicate
> definition of various types.
>
> Since it's redundant to include both <net/if_arp.h> and
> <linux/if_arp.h>, we simply force radvd to believe that
> <linux/if_arp.h> is not available by passing the appropriate autoconf
> cache variable. This gets us back to the previous situation, where
> <linux/if_arp.h> was never used.
>
> This has been tested with a uClibc toolchain using 4.11 kernel
> headers, and verified to work on glibc and musl with older kernel
> headers as well.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/949a75d96299394e4ac957746fa23a4b52f31b43/
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/radvd/radvd.mk | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-05-13 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 7:37 [Buildroot] [PATCH] radvd: fix build with 4.11 kernel headers Thomas Petazzoni
2017-05-13 13:14 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170513151430.19c863d9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox