From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/ntp: fix aarch64/mips build, -fPIC required
Date: Thu, 18 May 2017 11:11:24 +0200 [thread overview]
Message-ID: <20170518111124.76c71dbf@free-electrons.com> (raw)
In-Reply-To: <e27400a3-9128-57f5-57a3-d85cd307eb3d@imgtec.com>
Hello,
On Thu, 18 May 2017 10:02:26 +0100, Vicente Olivert Riera wrote:
> thank you very much for fixing this! It's sad that we have to use such
> kind of hacks or patches to fix something that shouldn't happen at all,
> since the ntp configure script can accept --with-pic=yes.
Not sure what you mean here. The ntp configure script detects if fPIC
is needed or not. The only thing that was missing is that this flag was
not propagated to ntpq/Makefile.am.
See my final commit,
https://git.buildroot.org/buildroot/commit/?id=7fde83cdf0da338937dae13144eea2923e5c2730.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-05-18 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 21:49 [Buildroot] [PATCH] package/ntp: fix aarch64/mips build, -fPIC required Romain Naour
2017-05-17 19:48 ` Thomas Petazzoni
2017-05-18 9:02 ` Vicente Olivert Riera
2017-05-18 9:11 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518111124.76c71dbf@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox