From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] toolchain: workaround musl/kernel headers conflict
Date: Thu, 18 May 2017 14:37:06 +0300 [thread overview]
Message-ID: <20170518113706.m6ava36e5jsgor4w@tarshish> (raw)
In-Reply-To: <20170518132448.3996edba@free-electrons.com>
Hi Thomas,
On Thu, May 18, 2017 at 01:24:48PM +0200, Thomas Petazzoni wrote:
> On Thu, 18 May 2017 14:17:44 +0300, Baruch Siach wrote:
> > Would that be better (untested)?
> >
> > diff --git a/toolchain/toolchain/toolchain.mk b/toolchain/toolchain/toolchain.mk
> > index e29837357a27..e15ceeb426fa 100644
> > --- a/toolchain/toolchain/toolchain.mk
> > +++ b/toolchain/toolchain/toolchain.mk
> > @@ -21,8 +21,10 @@ TOOLCHAIN_ADD_TOOLCHAIN_DEPENDENCY = NO
> > # IFF_DORMANT and IFF_ECHO, add another macro to suppress them in the
> > # kernel header, and avoid macro/enum conflict.
> > #
> > +# Kernel version 3.12 introduced the libc-compat.h header.
> > +#
> > # [1] http://www.openwall.com/lists/musl/2015/10/08/2
> > -ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
> > +ifeq ($(BR2_TOOLCHAIN_USES_MUSL)$(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12),yy)
> > define TOOLCHAIN_MUSL_KERNEL_HEADERS_COMPATIBILITY_HACK
> > $(SED) 's/^#if defined(__GLIBC__)$$/#if 1/' \
> > $(STAGING_DIR)/usr/include/linux/libc-compat.h
>
> Yes. The question is whether we will see those build failures due to
> kernel/userspace headers conflicts. Do you remember a simple
> package/scenario that triggers the problem?
The following two commits in this series, c0b756cac412 (Revert "bridge-utils:
fix build with musl"), and bae792e4c04 (Revert "norm: add patch to fix musl
build"), point at some likely build failure candidates.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
prev parent reply other threads:[~2017-05-18 11:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 13:27 [Buildroot] [PATCH v2 1/3] toolchain: workaround musl/kernel headers conflict Baruch Siach
2016-11-10 13:27 ` [Buildroot] [PATCH v2 2/3] Revert "bridge-utils: fix build with musl" Baruch Siach
2016-11-10 13:27 ` [Buildroot] [PATCH v2 3/3] Revert "norm: add patch to fix musl build" Baruch Siach
2016-11-13 21:33 ` [Buildroot] [PATCH v2 1/3] toolchain: workaround musl/kernel headers conflict Arnout Vandecappelle
2016-11-15 22:33 ` Thomas Petazzoni
2016-11-16 15:45 ` Baruch Siach
2016-11-16 15:55 ` Thomas Petazzoni
2016-11-16 16:25 ` Baruch Siach
2016-11-16 16:36 ` Thomas Petazzoni
2016-11-16 20:43 ` Baruch Siach
2016-11-16 22:30 ` Thomas Petazzoni
2017-05-17 13:33 ` Thomas Petazzoni
2017-05-18 4:57 ` Baruch Siach
2017-05-18 7:10 ` Thomas Petazzoni
2017-05-18 11:17 ` Baruch Siach
2017-05-18 11:24 ` Thomas Petazzoni
2017-05-18 11:37 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518113706.m6ava36e5jsgor4w@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox