From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] flex: remove disable-flex-binary-and-doc patch.
Date: Sat, 20 May 2017 17:38:17 +0200 [thread overview]
Message-ID: <20170520173817.01107631@free-electrons.com> (raw)
In-Reply-To: <20170520151752.22320-1-Adamduskett@outlook.com>
Hello,
On Sat, 20 May 2017 11:17:52 -0400, Adam Duskett wrote:
> Currently the flex makefile blindly links flex++ to flex in
> host/usr/bin, but because of the patch
> 0001-flex-disable-flex-binary-and-documentation.patch, this binary no
> longer exists, so it's a invalid simlink to begin with.
>
> Furthermore, host-checkpolicy requires host/usr/bin/flex to be present,
> and will fail with a "host/usr/bin/flex: Command not found" error.
>
> The patch itself says:
> "Since we prevent the flex binary to be built, we also need to prevent
> the documentation to be built, otherwise it will fail"
>
> Since the flex binary needs to be built, this patch is no longer necessary.
>
> Signed-off-by: Adam Duskett <Adamduskett@outlook.com>
There is indeed a bug in commit
e9a5f5843d0685c69b3c379b91bb9cce8864b8a2 in that it no longer
builds/installs the flex binary, for both the host and target variant.
We do want to build the flex binary when building host-flex (since it's
needed as a build dependency for other packages), but we do *NOT* want
to build the flex binary when building the target flex, because
building the flex binary is not possible on noMMU platforms.
Bottom line: e9a5f5843d0685c69b3c379b91bb9cce8864b8a2 is bogus, but
your patch is also bogus.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-05-20 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 15:17 [Buildroot] [PATCH 1/1] flex: remove disable-flex-binary-and-doc patch Adam Duskett
2017-05-20 15:38 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170520173817.01107631@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox