From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/redis: fix static linking with libatomic
Date: Sun, 28 May 2017 16:37:36 +0200 [thread overview]
Message-ID: <20170528163736.175ff4bc@free-electrons.com> (raw)
In-Reply-To: <20170525071934.31057-1-bernd.kuhls@t-online.de>
Hello,
On Thu, 25 May 2017 09:19:34 +0200, Bernd Kuhls wrote:
> # Uses __atomic_fetch_add_4
> +# src/Makefile contains a wrong linking order which breaks linking
> +# for static builds. We need to add -latomic to FINAL_LIBS to provide
The Makefile doesn't really contain a "wrong linking" order, it's
simply that LDFLAGS are used before the list of object files. So I've
reworded a bit the comment here.
> +# -latomic at the correct place in the linking command.
> ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> -REDIS_LIBATOMIC = -latomic
You forgot to adjust the place where REDIS_LIBATOMIC was used, so I've
adjusted that as well.
Applied to master with those two issues fixed.
Could you submit a patch upstream that adds something like
EXTRA_FINAL_LIBS:
FINAL_LIBS = -lm $(EXTRA_FINAL_LIBS)
This way we could nicely pass it from the environment.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-28 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 7:19 [Buildroot] [PATCH 1/1] package/redis: fix static linking with libatomic Bernd Kuhls
2017-05-28 14:37 ` Thomas Petazzoni [this message]
2017-06-01 14:25 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170528163736.175ff4bc@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox