Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] easy-rsa: new package
Date: Mon, 29 May 2017 22:15:34 +0200	[thread overview]
Message-ID: <20170529221534.72b6dfd3@free-electrons.com> (raw)
In-Reply-To: <1496088535-25501-1-git-send-email-julien@vdg.name>

Hello,

On Mon, 29 May 2017 22:08:54 +0200, Julien Viard de Galbert wrote:
> Signed-off-by: Julien Viard de Galbert <julien@vdg.name>
> ---
> Changes v1 -> v2
>   - Install missing file 'openssl-1.0.cnf'
>   - Add select BR2_PACKAGE_OPENSSL and update description (Thanks Romain Naour)
>   - Updated INSTALL call (Thanks Romain Naour)
> 
> Signed-off-by: Julien Viard de Galbert <julien@vdg.name>
> ---
>  package/Config.in              |  1 +
>  package/easy-rsa/Config.in     | 14 ++++++++++++++
>  package/easy-rsa/easy-rsa.hash |  2 ++
>  package/easy-rsa/easy-rsa.mk   | 19 +++++++++++++++++++

Please merge the change to the DEVELOPERS file in the same patch.


> diff --git a/package/Config.in b/package/Config.in
> index d57813c..14e5b14 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -942,6 +942,7 @@ menu "Crypto"
>  	source "package/botan/Config.in"
>  	source "package/ca-certificates/Config.in"
>  	source "package/cryptodev/Config.in"
> +	source "package/easy-rsa/Config.in"

easy-rsa is not a library, so it shouldn't go in Libraries->Crypto.

> +define EASY_RSA_INSTALL_TARGET_CMDS
> +    $(INSTALL) -D -m 0755 $(@D)/easyrsa $(TARGET_DIR)/usr/bin/easyrsa
> +    $(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/easy-rsa/x509-types
> +    $(INSTALL) -D -m 0644 $(@D)/x509-types/* $(TARGET_DIR)/etc/easy-rsa/x509-types
> +    $(INSTALL) -D -m 0644 $(@D)/openssl-1.0.cnf $(TARGET_DIR)/etc/easy-rsa/openssl-1.0.cnf
> +    $(INSTALL) -D -m 0644 $(@D)/vars.example $(TARGET_DIR)/etc/easy-rsa/vars

Use one tab for indentation here, not 4 spaces.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2017-05-29 20:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29 20:08 [Buildroot] [PATCH v2 1/2] easy-rsa: new package Julien Viard de Galbert
2017-05-29 20:08 ` [Buildroot] [PATCH v2 2/2] Update DEVELOPERS to track new easy-rsa package Julien Viard de Galbert
2017-05-29 20:15 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529221534.72b6dfd3@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox