From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/gnutls: disable for static build
Date: Mon, 29 May 2017 22:55:42 +0200 [thread overview]
Message-ID: <20170529225542.31554bd8@free-electrons.com> (raw)
In-Reply-To: <20170525163443.5234-1-romain.naour@gmail.com>
Hello,
On Thu, 25 May 2017 18:34:43 +0200, Romain Naour wrote:
> + --disable-static \
I understand the reasoning behind this change, but we don't do this in
any other package.
By passing --disable-static you are in fact making
BR2_STATIC_SHARED_LIBS act like BR2_SHARED_LIBS, so perhaps we should
rather depend on BR2_SHARED_LIBS.
But well, for now, we handle everywhere this static linking issue by
doing !BR2_STATIC_LIBS, which I believe is good enough.
So I've dropped the --disable-static part and applied to master. Sadly,
I just realized after pushing that I forgot to adjust the commit log
accordingly. Too bad :-/
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-05-29 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 16:34 [Buildroot] [PATCH v2] package/gnutls: disable for static build Romain Naour
2017-05-27 13:37 ` Bernd Kuhls
2017-05-29 20:55 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170529225542.31554bd8@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox