From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 6 Jun 2017 14:51:22 +0200 Subject: [Buildroot] [PATCH 2/2] package/ffmpeg: fix static linking with alsa In-Reply-To: <871sqxe1xb.fsf@dell.be.48ers.dk> References: <20170601203930.1069-1-bernd.kuhls@t-online.de> <20170601203930.1069-2-bernd.kuhls@t-online.de> <20170605144812.36b6f0e3@free-electrons.com> <871sqxe1xb.fsf@dell.be.48ers.dk> Message-ID: <20170606145122.0b36d3cb@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Tue, 06 Jun 2017 14:27:44 +0200, Peter Korsgaard wrote: > > And I believe this patch would be upstreamable. Peter, what do you > > think? > > Calling it bogus is imho a bit harsh, but yeah - Getting it fixed > upstream so it works without seq would be nicer. I think it's bogus because the root of the problem is in alsa-lib, but the proposed fix requires to touch potentially all users of alsa-lib. So even if we decide not to patch alsa-lib, the proper fix would have been: config BR2_PACKAGE_ALSA_LIB_RAWMIDI bool "rawmidi" + BR2_PACKAGE_ALSA_LIB_SEQ default y Because right now, the library produced by alsa-lib is broken, and this is worked around in packages using alsa-lib rather than alsa-lib itself. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com