From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
Date: Tue, 6 Jun 2017 21:23:14 +0200 [thread overview]
Message-ID: <20170606212314.069892f2@free-electrons.com> (raw)
In-Reply-To: <1496774645.3962.1.camel@embedded.rocks>
Hello,
On Tue, 06 Jun 2017 20:44:05 +0200, J?rg Krause wrote:
> > > config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> > > bool
> > > - default y if BR2_nios2
> > > - default y if BR2_ARM_CPU_ARMV4
> > > - default y if BR2_ARM_CPU_ARMV5
> > > - default y if BR2_sparc_v8
> > > + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \
> > > + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \
> > > + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> >
> > This feels very complicated. What about just:
> >
> > depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
>
> Wouldn't that be rather:
>
> """
> config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> """
No because that would make the option "y" as soon as you have gcc < 7.
But we want the option to be "y" only if you have gcc < 7 *and* you're
using one of nios2, ARMv4/v5 or sparc v8.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-06-06 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 14:08 [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7 Jörg Krause
2017-06-06 15:32 ` Thomas Petazzoni
2017-06-06 18:44 ` Jörg Krause
2017-06-06 19:23 ` Thomas Petazzoni [this message]
2017-06-06 19:35 ` Jörg Krause
2017-06-06 19:42 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606212314.069892f2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox