From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 6 Jun 2017 21:23:14 +0200 Subject: [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7 In-Reply-To: <1496774645.3962.1.camel@embedded.rocks> References: <20170606140850.5823-1-joerg.krause@embedded.rocks> <20170606173222.537500c6@free-electrons.com> <1496774645.3962.1.camel@embedded.rocks> Message-ID: <20170606212314.069892f2@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Tue, 06 Jun 2017 20:44:05 +0200, J?rg Krause wrote: > > > config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 > > > bool > > > - default y if BR2_nios2 > > > - default y if BR2_ARM_CPU_ARMV4 > > > - default y if BR2_ARM_CPU_ARMV5 > > > - default y if BR2_sparc_v8 > > > + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \ > > > + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \ > > > + !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > > This feels very complicated. What about just: > > > > depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > Wouldn't that be rather: > > """ > config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 > default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > """ No because that would make the option "y" as soon as you have gcc < 7. But we want the option to be "y" only if you have gcc < 7 *and* you're using one of nios2, ARMv4/v5 or sparc v8. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com