Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 1/2] package/libv4l: upstream patches for noMMU platform
Date: Fri, 9 Jun 2017 12:01:42 +0200	[thread overview]
Message-ID: <20170609120142.6db8e35a@free-electrons.com> (raw)
In-Reply-To: <a69f63ba-b2c9-6b25-560d-c5c0ad8fb995@st.com>

Hello,

On Fri, 9 Jun 2017 09:33:24 +0000, Hugues FRUCHET wrote:

> > Thanks a lot for those patches! It's mostly good, but I have a few
> > comments. First of all, both of your patches should be squashed into
> > just one, because they serve the same purpose: enabling libv4l on
> > nommu/static linking configurations.  
> 
> I have done it this way in order that you can easily revert the patch 
> 1/2 when bumping to v4l-utils 1.12.6 release (or 1.12.7, I don't know 
> the frequency of releases).
> The patch 2/2 is specific to buildroot and must remain.

When we bump a package version and patches need to be dropped, we don't
revert the commit that was adding them. We simply drop the patches in
the commit doing the version bump, and indicate in the commit log why
they are dropped (ideally with a reference to the upstream commit).

> >> +Subject: [PATCH 4/9] configure.ac: clarify configure summary  
> > 
> > Please generate the package/libv4l/ patch series with "git format-patch
> > -N" so  that the prefix is just [PATCH] and not [PATCH X/Y].  
> Will do ! I'll miss also the prefix [buildroot]...

Not sure what you mean by the "prefix [buildroot]". The [Buildroot] is
added by the mailing list software, and has nothing to do with how
patches are generated/applied.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-06-09 10:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 10:12 [Buildroot] [PATCH v1 0/2] v4l-utils build on noMMU platform Hugues Fruchet
2017-06-07 10:12 ` [Buildroot] [PATCH v1 1/2] package/libv4l: upstream patches for " Hugues Fruchet
2017-06-08 19:54   ` Thomas Petazzoni
2017-06-09  9:33     ` Hugues FRUCHET
2017-06-09 10:01       ` Thomas Petazzoni [this message]
2017-06-09 10:45   ` [Buildroot] From: Hugues Fruchet <hugues.fruchet@st.com> Hugues Fruchet
2017-06-09 10:45     ` [Buildroot] [PATCH v2] package/libv4l: build of v4l2 utilities on noMMU platform Hugues Fruchet
2017-06-09 10:45     ` [Buildroot] [PATCH v2] package/libv4l: toolchain w/ locale is not mandatory Hugues Fruchet
2017-06-07 10:12 ` [Buildroot] [PATCH v1 2/2] package/libv4l: build of v4l2 utilities on noMMU platform Hugues Fruchet
2017-06-08 19:57   ` Thomas Petazzoni
2017-06-09  9:39     ` Hugues FRUCHET
2017-06-09 10:03       ` Thomas Petazzoni
2017-06-09 12:18 ` [Buildroot] [PATCH v2] v4l-utils build " Hugues Fruchet
2017-06-09 12:18   ` [Buildroot] [PATCH v2] package/libv4l: build of v4l2 utilities " Hugues Fruchet
2017-06-09 12:18   ` [Buildroot] [PATCH v2] package/libv4l: toolchain w/ locale is not mandatory Hugues Fruchet
2017-06-10 21:33   ` [Buildroot] [PATCH v2] v4l-utils build on noMMU platform Thomas Petazzoni
2017-06-12  9:03     ` Hugues FRUCHET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609120142.6db8e35a@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox