Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] syslinux: Add patch to build with the latest gnu-efi release
Date: Mon, 12 Jun 2017 15:32:42 +0200	[thread overview]
Message-ID: <20170612153242.6f5ddb57@windsurf.lan> (raw)
In-Reply-To: <20170612152032.5c2c99ae@armant.office.greenbone.net>

Hello,

On Mon, 12 Jun 2017 15:20:32 +0200, Beno?t Allard wrote:

> > The problem is that it builds a tool called "wrapper" with the
> > cross-compiler, and then tries to run it on the host. It might work if
> > your host and target use the same architecture and libc. Here, I'm
> > using the same architecture (x86-64) but not the same libc (glibc for
> > the host, uclibc for the target).
> > 
> > Do you think you could have a look?  
> 
> I just sent a patch about that. Thanks for noticing, and reporting the
> issue.

Thanks, I'll have a look.

> > Nit: please use 'git format-patch -N' to generate your patches. This
> > will generate patches with [PATCH] as a prefix instead of [PATCH X/Y].
> > Indeed, the 1/3, 2/3 and 3/3 in your patches don't make sense: your
> > patches are patches 7, 8 and 9! To avoid this, in Buildroot, we have
> > decided to not add numbering inside the patches themselves.
> >   
> 
> Maybe it would make sense to add the '-N' to the example command-lines
> in the manual ? ;) ( That would be section 21.5.2 and 21.5.4)

No, because those sections are about formatting patches for Buildroot,
not patches for packages.

But it should indeed be explained somewhere in the manual, i.e in
https://buildroot.org/downloads/manual/manual.html#patch-policy.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-06-12 13:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 10:20 [Buildroot] [PATCH] syslinux: Add patch to build with the latest gnu-efi release Benoît Allard
2017-06-11 13:37 ` Thomas Petazzoni
2017-06-12 13:20   ` Benoît Allard
2017-06-12 13:32     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612153242.6f5ddb57@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox