From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [PATCH v3] azure-iot-sdk-c: New package
Date: Mon, 12 Jun 2017 22:45:22 +0200 [thread overview]
Message-ID: <20170612224522.20315f78@windsurf.lan> (raw)
In-Reply-To: <1497297091-28452-1-git-send-email-nerv@dawncrow.de>
Hello,
On Mon, 12 Jun 2017 21:51:31 +0200, Andr? Hentschel wrote:
> I use 2017-05-05 now, because newer versions will need some fixes (maybe as patches), so let's start with a cleaner version that just works.
Don't use "personal" sentences in commit logs, and rewrap commit logs
at 72 characters. So something like:
"""
Despite newer versions being available, this patch creates a package
for version 2017-05-05, because newer version have issues that need to
be addressed.
"""
> Still, the projects install target installs the wrong files, that's
> why commands are needed for staging_install and target_install.
Isn't it better to patch the package build system to fix those issues?
>
> v2: Rework the package with help from Arnouts comments
> v3: Explain some things in the commit message
The commit log should go...
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
> ---
... here.
I typically do that by putting "---" below my SoB line, and writing the
commit log (git commit --amend).
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-06-12 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 19:51 [Buildroot] [PATCH] [PATCH v3] azure-iot-sdk-c: New package André Hentschel
2017-06-12 20:45 ` Thomas Petazzoni [this message]
2017-06-22 15:14 ` André Hentschel
2017-06-12 22:19 ` Arnout Vandecappelle
2017-06-22 15:14 ` André Hentschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612224522.20315f78@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox