Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] board: Add nanopi-m1 Support
Date: Thu, 15 Jun 2017 22:15:08 +0200	[thread overview]
Message-ID: <20170615221508.27a297ab@windsurf.lan> (raw)
In-Reply-To: <1497547465-15445-1-git-send-email-chakra@openedev.com>

Hello,

On Thu, 15 Jun 2017 22:54:25 +0530, Chakra Divi wrote:
> Add initial support for nanopi-m1 board
> with below features
> - U-Boot 2017.07-rc1

Are you using this -rc1 because it's the first U-Boot version with
support for this board?

> - Linux 4.11
> - Default packages from buildroot
> 
> Created a new folder nanopi under buildroot
> board; any new board for nanopi can be added
> here

We already have the support for another nanopi board
in board/nanopi-neo/. Perhaps some refactoring is needed?

Also is "nanopi" really the vendor name? We normally like to have
board/<vendor>/<boardname>/.

> diff --git a/board/nanopi/post-image.sh b/board/nanopi/post-image.sh
> new file mode 100755
> index 0000000..359b4c9
> --- /dev/null
> +++ b/board/nanopi/post-image.sh
> @@ -0,0 +1,14 @@
> +#!/bin/sh
> +
> +BOARD_DIR="$(dirname $0)"
> +GENIMAGE_CFG="${BOARD_DIR}/genimage.cfg"
> +GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp"
> +
> +rm -rf "${GENIMAGE_TMP}"
> +
> +genimage                               \
> +	--rootpath "${TARGET_DIR}"     \
> +	--tmppath "${GENIMAGE_TMP}"    \
> +	--inputpath "${BINARIES_DIR}"  \
> +	--outputpath "${BINARIES_DIR}" \
> +	--config "${GENIMAGE_CFG}"

Could you use support/scripts/genimage.sh instead ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-06-15 20:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 17:24 [Buildroot] [PATCH] board: Add nanopi-m1 Support Chakra Divi
2017-06-15 20:15 ` Thomas Petazzoni [this message]
2017-06-16 16:13   ` Chakra D
2017-06-15 21:53 ` Arnout Vandecappelle
2017-06-16 16:22   ` Chakra D
2017-06-16 16:36     ` Chakra D
2017-06-16 21:08     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170615221508.27a297ab@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox