From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/6] board: Add support for Engicam i.CoreM6 DualLite/Solo boards
Date: Tue, 20 Jun 2017 07:46:35 +0200 [thread overview]
Message-ID: <20170620074635.6c036cfc@windsurf.home> (raw)
In-Reply-To: <CAMty3ZDRMu13a1tZfah8m39CxBNrNnwEYEcEQeDRMqt=6N74Rg@mail.gmail.com>
Hello,
On Tue, 20 Jun 2017 07:55:26 +0530, Jagan Teki wrote:
> >> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05"
> >> -BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc"
> >> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05-rc1"
> >
> > This doesn't make sense. Why are you rolling back from 2017.05 to
> > 2017.05-rc1 ?
> >
> > I assume a feature present in the -rc1 is also present in the final
> > release. Otherwise, it means the feature has been reverted, which is a
> > bad sign.
> >
> > Maybe you wanted to use 2017.07-rc1 instead?
>
> Yes I need to use -rc1 because this feature is present in it. I was
> trying for explicitly applying patches, but those are more.
Did you read what I wrote? Your patch is using 2017.05-rc1, which is
most likely not what you intended, because 2017.05 final is available.
Wasn't your intention to use 2017.07-rc1.
Please re-read carefully your patch and my review. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-06-20 5:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 7:27 [Buildroot] [PATCH v4 0/6] Board: Add Engicam i.MX6 SOMs Jagan Teki
2017-06-19 7:27 ` [Buildroot] [PATCH v4 1/6] board: Add support for Engicam i.CoreM6 DualLite/Solo boards Jagan Teki
2017-06-19 20:17 ` Thomas Petazzoni
2017-06-20 2:25 ` Jagan Teki
2017-06-20 5:46 ` Thomas Petazzoni [this message]
2017-06-20 8:56 ` Jagan Teki
2017-06-19 7:27 ` [Buildroot] [PATCH v4 2/6] board: engicam: Rename defconfig engicam_imx6qdl_icore_mmc_defconfig Jagan Teki
2017-06-19 20:19 ` Thomas Petazzoni
2017-06-20 2:30 ` Jagan Teki
2017-06-20 5:47 ` Thomas Petazzoni
2017-06-19 7:27 ` [Buildroot] [PATCH v4 3/6] board: Add support for Engicam i.CoreM6 RQS SOM Jagan Teki
2017-06-19 7:27 ` [Buildroot] [PATCH v4 4/6] board: engicam: Add icorem6 for i.CoreM6 support Jagan Teki
2017-06-19 7:27 ` [Buildroot] [PATCH v4 5/6] board: Add support for Engicam GEAM6UL SOM Jagan Teki
2017-06-19 7:27 ` [Buildroot] [PATCH v4 6/6] board: Add support for Engicam Is.IoT MX6UL SOM Jagan Teki
2017-06-19 7:41 ` [Buildroot] [PATCH v4 0/6] Board: Add Engicam i.MX6 SOMs Thomas Petazzoni
2017-06-19 8:08 ` Jagan Teki
2017-06-19 12:18 ` Thomas Petazzoni
2017-06-19 13:00 ` Jagan Teki
2017-06-19 13:24 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620074635.6c036cfc@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox