Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/x264: disable optional ffmpeg support
Date: Tue, 20 Jun 2017 22:31:41 +0200	[thread overview]
Message-ID: <20170620223141.255a2c41@windsurf.lan> (raw)
In-Reply-To: <20170605162238.8413-1-bernd.kuhls@t-online.de>

Hello,

On Mon,  5 Jun 2017 18:22:37 +0200, Bernd Kuhls wrote:
> In buildroot ffmpeg uses x264 as optional dependency if
> BR2_PACKAGE_FFMPEG_GPL is enabled at the same time.
> 
> If BR2_PACKAGE_FFMPEG_GPL is disabled and ffmpeg is built without x264
> support before x264 itself is build, x264 picks up certain ffmpeg libs
> as optional dependency leading to build errors because x264 does not
> correctly link statically against ffmpeg.
> 
> To avoid a circular dependency and to avoid teaching x264 how to
> correctly link statically with ffmpeg we just disable all ffmpeg-
> related options.
> 
> Fixes
> http://autobuild.buildroot.net/results/36a/36abb5b8f3aab57fb7b63056b216b4a58143ee3e/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/x264/x264.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both patches applied, thanks. On the second patch, you forgot to update
the hash, so I've done so. You probably forgot because back then, we
were not checking the hashes of git-downloaded packages. But now we
are, so hashes should be correct.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2017-06-20 20:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 16:22 [Buildroot] [PATCH 1/2] package/x264: disable optional ffmpeg support Bernd Kuhls
2017-06-05 16:22 ` [Buildroot] [PATCH 2/2] package/x264: bump version Bernd Kuhls
2017-06-20 20:31 ` Thomas Petazzoni [this message]
2017-06-26  7:56   ` [Buildroot] [PATCH 1/2] package/x264: disable optional ffmpeg support Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620223141.255a2c41@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox