Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/7] janus-gateway: add transports section to config.
Date: Tue, 20 Jun 2017 23:13:10 +0200	[thread overview]
Message-ID: <20170620231310.570b2ba4@windsurf.lan> (raw)
In-Reply-To: <20170615121314.1485-2-aduskett@codeblue.com>

Hello,

On Thu, 15 Jun 2017 08:13:09 -0400, Adam Duskett wrote:
> janus-gateway supports many different transports, and currently
> there is no implicit way to turn them off or on.  Instead, if the
> dependency happens to be built, then the transport is enabled.
> 
> Create a transports section in the config file and add
> BR2_PACKAGE_JANUS_REST as the first transport.
> 
> Signed-off-by: Adam Duskett <aduskett@codeblue.com>
> ---
>  package/janus-gateway/Config.in        | 6 ++++++
>  package/janus-gateway/janus-gateway.mk | 7 +++++++
>  2 files changed, 13 insertions(+)

I've applied patches 2 to 7. However, it would be nice to be a little
bit more careful in the patches. I had to fix a few things:

 * The title had a typo in most of the commits: gatway -> gateway

 * Inconsistent ending of the titles: some ending with a final dot,
   some not. The latter being the preferred choice.

 * You forgot to propagate the dependencies of the packages being
   selected, and adding the corresponding Config.in comment.

 * You forgot to use alphabetic ordering where appropriate.

All those are minor nits, but they add up, and need to be fixed before
applying the patches.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2017-06-20 21:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 12:13 [Buildroot] [PATCH 1/7] janus-gateway: bump to version 0.2.3 Adam Duskett
2017-06-15 12:13 ` [Buildroot] [PATCH 2/7] janus-gateway: add transports section to config Adam Duskett
2017-06-20 21:13   ` Thomas Petazzoni [this message]
2017-06-15 12:13 ` [Buildroot] [PATCH 3/7] janus-gatway: add websockets to transport section Adam Duskett
2017-06-15 12:13 ` [Buildroot] [PATCH 4/7] janus-gatway: add rabbitmq to transports section Adam Duskett
2017-06-15 12:13 ` [Buildroot] [PATCH 5/7] janus-gatway: add mqtt to transport section Adam Duskett
2017-06-15 12:13 ` [Buildroot] [PATCH 6/7] janus-gatway: add unix-sockets " Adam Duskett
2017-06-15 12:13 ` [Buildroot] [PATCH 7/7] DEVELOPERS: Add janus-gateway to Adam Duskett Adam Duskett
2017-06-15 21:34 ` [Buildroot] [PATCH 1/7] janus-gateway: bump to version 0.2.3 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620231310.570b2ba4@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox