Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] barebox: support multiple image files
Date: Wed, 21 Jun 2017 21:43:05 +0200	[thread overview]
Message-ID: <20170621214305.6ae863f9@windsurf> (raw)
In-Reply-To: <20170621070353.16521-1-m.niestroj@grinn-global.com>

Hello,

On Wed, 21 Jun 2017 09:03:53 +0200, Marcin Niestroj wrote:

>  define $(1)_INSTALL_IMAGES_CMDS
>  	if test -n "$$($(1)_IMAGE_FILE)"; then \

I've renamed this variable to $(1)_IMAGE_FILES, because it now contains
potentially multiple files.

Applied with this fixed.

BTW, it would be nice to provide a test case for this feature in our
testing infrastructure, see support/testing/. I think in the long run
we should require the addition of test cases when such features are
added.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-06-21 19:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  7:03 [Buildroot] [PATCH v2] barebox: support multiple image files Marcin Niestroj
2017-06-21 19:43 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170621214305.6ae863f9@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox