Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] xr819-xradio: new package
Date: Wed, 21 Jun 2017 22:41:39 +0200	[thread overview]
Message-ID: <20170621224139.720d19cc@windsurf> (raw)
In-Reply-To: <20170618184200.31167-2-geomatsi@gmail.com>

Hello,

On Sun, 18 Jun 2017 21:41:59 +0300, Sergey Matyukevich wrote:
> This patch adds xradio wireless driver for SDIO WiFi chip XR819.
> The out-of-tree driver is sourced from fifteenhex's work
> on github https://github.com/fifteenhex/xradio
> 
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>

Thanks for your contribution. I've applied, after some minor changes,
see below.

> ---
>  package/Config.in                      |  1 +
>  package/xr819-xradio/Config.in         | 10 ++++++++++
>  package/xr819-xradio/xr819-xradio.hash |  2 ++
>  package/xr819-xradio/xr819-xradio.mk   | 13 +++++++++++++
>  4 files changed, 26 insertions(+)
>  create mode 100644 package/xr819-xradio/Config.in
>  create mode 100644 package/xr819-xradio/xr819-xradio.hash
>  create mode 100644 package/xr819-xradio/xr819-xradio.mk

You forgot to add an entry to the DEVELOPERS file, so I've added one.

> diff --git a/package/xr819-xradio/Config.in b/package/xr819-xradio/Config.in
> new file mode 100644
> index 000000000..5539004be
> --- /dev/null
> +++ b/package/xr819-xradio/Config.in
> @@ -0,0 +1,10 @@
> +comment "xradio wireless driver needs a Linux kernel to be built"

The comment should mention the package name as-is, i.e:

comment "xr819-xradio needs a Linux kernel to be built.

I've fixed both issues and applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-06-21 20:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-18 18:41 [Buildroot] [PATCH 0/2] Add xradio wireless driver Sergey Matyukevich
2017-06-18 18:41 ` [Buildroot] [PATCH 1/2] xr819-xradio: new package Sergey Matyukevich
2017-06-21 20:41   ` Thomas Petazzoni [this message]
2017-06-22  7:55     ` Sergey Matyukevich
2017-06-22  8:10       ` Thomas Petazzoni
2017-06-22  8:49         ` Sergey Matyukevich
2017-06-22  9:47         ` Peter Korsgaard
2017-06-22  9:50           ` Thomas Petazzoni
2017-06-22 10:05             ` Peter Korsgaard
2017-06-18 18:42 ` [Buildroot] [PATCH 2/2] orangepi_zero_defconfig: add xradio wireless driver Sergey Matyukevich
2017-06-21 20:41   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170621224139.720d19cc@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox