From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] qt5multimedia: conditionally add alsa-lib to dependencies
Date: Tue, 27 Jun 2017 21:20:00 +0200 [thread overview]
Message-ID: <20170627212000.5e09dca9@gmx.net> (raw)
In-Reply-To: <1498549990-3548-3-git-send-email-brgl@bgdev.pl>
Hello Bartoz,
On Tue, 27 Jun 2017 09:53:09 +0200, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> Qt5Multimedia builds the alsa plugin if it detects libasound in the
> system. Add alsa-lib to dependencies if BR2_PACKAGE_ALSA_LIB is
> selected.
>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
> package/qt5/qt5multimedia/qt5multimedia.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/qt5/qt5multimedia/qt5multimedia.mk b/package/qt5/qt5multimedia/qt5multimedia.mk
> index 19312ff..062d980 100644
> --- a/package/qt5/qt5multimedia/qt5multimedia.mk
> +++ b/package/qt5/qt5multimedia/qt5multimedia.mk
> @@ -30,6 +30,10 @@ ifeq ($(BR2_PACKAGE_LIBGLIB2)$(BR2_PACKAGE_PULSEAUDIO),yy)
> QT5MULTIMEDIA_DEPENDENCIES += libglib2 pulseaudio
> endif
>
> +ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
> +QT5MULTIMEDIA_DEPENDENCIES += alsa-lib
> +endif
> +
> define QT5MULTIMEDIA_CONFIGURE_CMDS
> (cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/qmake)
> endef
Thanks for taking care of it...
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
next prev parent reply other threads:[~2017-06-27 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 7:53 [Buildroot] [PATCH v2 0/2] qt5multimedia: add missing dependencies Bartosz Golaszewski
2017-06-27 7:53 ` [Buildroot] [PATCH v2 1/2] qt5multimedia: conditionally add pulseaudio & libglib2 to dependencies Bartosz Golaszewski
2017-06-27 19:18 ` Peter Seiderer
2017-06-27 7:53 ` [Buildroot] [PATCH v2 2/2] qt5multimedia: conditionally add alsa-lib " Bartosz Golaszewski
2017-06-27 19:20 ` Peter Seiderer [this message]
2017-06-27 7:55 ` [Buildroot] [PATCH v2 0/2] qt5multimedia: add missing dependencies Bartosz Golaszewski
2017-07-01 17:39 ` Thomas Petazzoni
2017-07-02 15:53 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627212000.5e09dca9@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox