Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: don't run "menuconfig" automatically
Date: Sat, 1 Jul 2017 10:26:22 +0200	[thread overview]
Message-ID: <20170701102622.01fefe49@windsurf.home> (raw)
In-Reply-To: <20170701082446.24664-1-arnout@mind.be>

Hello,

On Sat, 1 Jul 2017 10:24:46 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> Since forever, we run 'menuconfig' automatically on an unconfigured
> tree. However, this does not help users that much:
> - If they read the documentation, they should already know to run
>   make menuconfig first.
> - If they haven't read the documentation, dropping them in menuconfig
>   isn't very helpful.
> - It's a likely that the user didn't intend to be in an unconfigured
>   tree (e.g. wrong O= specified), so starting menuconfig (and polluting
>   this wrong O= directory) is not very helpful.
> - It's possible that the user really doesn't want menuconfig, but
>   instead needs xconfig, or some defconfig, or ...
> 
> So, instead of trying to guess what the user needs, print an error and
> let the user decide what to do next.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2017-07-01  8:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-01  8:24 [Buildroot] [PATCH] Makefile: don't run "menuconfig" automatically Arnout Vandecappelle
2017-07-01  8:26 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170701102622.01fefe49@windsurf.home \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox