Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6] autofs: allow to use libtirpc instead of internal C implementation
Date: Sat, 1 Jul 2017 10:40:56 +0200	[thread overview]
Message-ID: <20170701104056.777ff0fb@windsurf.home> (raw)
In-Reply-To: <20170630085229.GA9830@waldemar-brodkorb.de>

Hello,

On Fri, 30 Jun 2017 10:52:29 +0200, Waldemar Brodkorb wrote:

>  ...fig-to-search-for-libtirpc-to-fix-cross-c.patch | 957 +++++++++++++++++++++

This is a fairly massive patch. From the reading of your changelog, I
can see you're working with upstream to get it merged. Do you think it
will be merged soon?


> +ifeq ($(BR2_TOOLCHAIN_HAS_NATIVE_RPC),)

I think this should instead be:

ifeq ($(BR2_PACKAGE_LIBTIRPC),y)

indeed, even if you have native RPC support, but have decided to anyway
enable libtirpc, it makes sense to use it IMO.

> +AUTOFS_CONF_OPTS += --with-libtirpc
> +AUTOFS_DEPENDENCIES += libtirpc
> +else
> +AUTOFS_CONF_OPTS += --without-libtirpc
> +endif
> +
>  $(eval $(autotools-package))

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-07-01  8:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30  8:52 [Buildroot] [PATCH v6] autofs: allow to use libtirpc instead of internal C implementation Waldemar Brodkorb
2017-07-01  8:40 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170701104056.777ff0fb@windsurf.home \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox