From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/7 v4] tools: move size-stat-compare out of support/scripts/
Date: Sat, 1 Jul 2017 18:27:17 +0200 [thread overview]
Message-ID: <20170701182717.30bda462@windsurf.home> (raw)
In-Reply-To: <CAAXf6LVF7gAph5SJqCAPjGgagckQOyO0Ud_Xqbdj=+kTGqzY5g@mail.gmail.com>
Hello,
On Sat, 1 Jul 2017 18:02:57 +0200, Thomas De Schampheleire wrote:
> > diff --git a/tools/readme.txt b/tools/readme.txt
> > index fc1108fded..dd8a1d4494 100644
> > --- a/tools/readme.txt
> > +++ b/tools/readme.txt
> > @@ -11,6 +11,12 @@ get-developpers
> > of Buildroot, so they can be Cc:ed on a mail. Accepts a patch as
> > input, a package name or and architecture name.
> >
> > +size-stat-compare
> > + a script to compare the rootfs size between two differnt Buildroot
>
> You must have missed my comment about 'differnt' -> 'different'
>
> > + configurations. This can be used to identify the size impact of
> > + a specific option, or of a set of specific options, or an update
> > + to a newer Buildroot version...
>
> While you're at it, the last clause would either also need 'of': 'or
> of an update...',
> or otherwise it would need to be removed on the second clause, but now
> it is inconsistent.
Sorry, I have already pushed. Can you send a patch? :-)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-01 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 14:31 [Buildroot] [PATCH 0/7 v4] tools: add a directory to contain usefull user-facing tools Yann E. MORIN
2017-07-01 14:31 ` [Buildroot] [PATCH 1/7 v4] tools: move test-pkg out of support/scripts Yann E. MORIN
2017-07-01 14:31 ` [Buildroot] [PATCH 2/7 v4] tools: move get-developers out of support/scripts/ Yann E. MORIN
2017-07-01 14:31 ` [Buildroot] [PATCH 3/7 v4] tools: move check-package " Yann E. MORIN
2017-07-01 14:31 ` [Buildroot] [PATCH 4/7 v4] tools: move size-stat-compare " Yann E. MORIN
2017-07-01 16:02 ` Thomas De Schampheleire
2017-07-01 16:27 ` Thomas Petazzoni [this message]
2017-07-01 16:33 ` Yann E. MORIN
2017-07-01 14:31 ` [Buildroot] [PATCH 5/7 v4] tools: move scancpan " Yann E. MORIN
2017-07-01 14:31 ` [Buildroot] [PATCH 6/7 v4] tools: move scanpypi " Yann E. MORIN
2017-07-01 14:31 ` [Buildroot] [PATCH 7/7 v4] tools: new tool to filter the output of make Yann E. MORIN
2017-07-01 16:26 ` [Buildroot] [PATCH 0/7 v4] tools: add a directory to contain usefull user-facing tools Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170701182717.30bda462@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox