From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3 v3] package/ifupdown-scripts: allow use with a custom skeleton
Date: Sun, 2 Jul 2017 18:37:11 +0200 [thread overview]
Message-ID: <20170702163711.GA2989@scaer> (raw)
In-Reply-To: <238a54c3-4de7-35bf-bf51-a09061fb88b6@mind.be>
Arnout, All,
On 2017-07-02 18:08 +0200, Arnout Vandecappelle spake thusly:
> On 02-07-17 16:35, Yann E. MORIN wrote:
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Arnout Vandecappelle <arnout@mind.be>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> You'll also send a patch adding a select to package/ifupdown/Config.in?
As discussed IRL, it is also a legit use-case to have ifupdown without
out scripts.
Thanks for the review! :-)
Regards,
Yann E. MORIN.
> Regards,
> Arnout
>
> > ---
> > package/ifupdown-scripts/Config.in | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/package/ifupdown-scripts/Config.in b/package/ifupdown-scripts/Config.in
> > index 7086253a03..7064d58fec 100644
> > --- a/package/ifupdown-scripts/Config.in
> > +++ b/package/ifupdown-scripts/Config.in
> > @@ -1,8 +1,7 @@
> > config BR2_PACKAGE_IFUPDOWN_SCRIPTS
> > - bool
> > - depends on BR2_ROOTFS_SKELETON_DEFAULT
> > + bool "ifupdown scripts"
> > depends on !BR2_PACKAGE_SYSTEMD_NETWORKD
> > - default y
> > + default y if BR2_ROOTFS_SKELETON_DEFAULT
> > help
> > Set of scripts used by ifupdown (either the standalone one, or the
> > busybox one) to bring network up, or tear it down.
> >
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-07-02 16:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-02 14:35 [Buildroot] [PATCH 0/3 v3] skeleton: move ifupdown script to their own package Yann E. MORIN
2017-07-02 14:35 ` [Buildroot] [PATCH 1/3 v3] package/ifupdown-scripts: new package Yann E. MORIN
2017-07-02 16:04 ` Arnout Vandecappelle
2017-07-02 16:05 ` Arnout Vandecappelle
2017-07-03 9:38 ` Yann E. MORIN
2017-07-02 14:35 ` [Buildroot] [PATCH 2/3 v3] package/ifupdown-scripts: not needed for systemd-networkd Yann E. MORIN
2017-07-02 16:06 ` Arnout Vandecappelle
2017-07-02 14:35 ` [Buildroot] [PATCH 3/3 v3] package/ifupdown-scripts: allow use with a custom skeleton Yann E. MORIN
2017-07-02 16:08 ` Arnout Vandecappelle
2017-07-02 16:37 ` Yann E. MORIN [this message]
2017-07-04 21:49 ` [Buildroot] [PATCH 0/3 v3] skeleton: move ifupdown script to their own package Thomas Petazzoni
2017-07-04 21:56 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170702163711.GA2989@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox