From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [Patch v6 1/7] pkg-virtual: fix host dependencies handling
Date: Sun, 2 Jul 2017 23:40:31 +0200 [thread overview]
Message-ID: <20170702234031.09d58336@windsurf> (raw)
In-Reply-To: <20170625205614.6723-2-eric.le.bihan.dev@free.fr>
Hello,
On Sun, 25 Jun 2017 22:56:08 +0200, Eric Le Bihan wrote:
> If $(BR2_PACKAGE_HAS_HOST_FOO) is defined, then the pkg-virtual
> infrastructure will check if $(BR2_PACKAGE_PROVIDES_HOST_FOO) is not
> empty.
>
> But later, $(BR2_PACKAGE_HOST_FOO_DEPENDENCIES) will be set from
> $(BR2_PACKAGE_PROVIDES_FOO), ignoring $(BR2_PACKAGE_PROVIDES_HOST_FOO).
>
> So fix this discrepancy by setting $(BR2_PACKAGE_HOST_FOO_DEPENDENCIES)
> from $(BR2_PACKAGE_PROVIDES_FOO) only if $(BR2_PACKAGE_PROVIDES_HOST_FOO)
> is empty.
>
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> ---
> package/pkg-virtual.mk | 4 ++++
> 1 file changed, 4 insertions(+)
Applied to master, after adding the comments suggested by Arnout.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-02 21:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-25 20:56 [Buildroot] [Patch v6 0/7] Add support for the Rust programming language Eric Le Bihan
2017-06-25 20:56 ` [Buildroot] [Patch v6 1/7] pkg-virtual: fix host dependencies handling Eric Le Bihan
2017-07-01 13:07 ` Arnout Vandecappelle
2017-07-02 21:40 ` Thomas Petazzoni [this message]
2017-06-25 20:56 ` [Buildroot] [Patch v6 2/7] rustc: new virtual package Eric Le Bihan
2017-06-25 20:56 ` [Buildroot] [Patch v6 3/7] rust-bin: new package Eric Le Bihan
2017-06-25 20:56 ` [Buildroot] [Patch v6 4/7] rustc: expose host variant in menuconfig Eric Le Bihan
2017-06-25 20:56 ` [Buildroot] [Patch v6 5/7] rust-bootstrap: new package Eric Le Bihan
2017-06-25 20:56 ` [Buildroot] [Patch v6 6/7] cargo-bootstrap: " Eric Le Bihan
2017-06-25 20:56 ` [Buildroot] [Patch v6 7/7] rust: " Eric Le Bihan
2017-06-28 9:20 ` [Buildroot] [Patch v6 0/7] Add support for the Rust programming language Adrian Perez de Castro
2017-07-01 11:28 ` Eric Le Bihan
2017-07-01 13:01 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170702234031.09d58336@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox