Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Martin <s.martin49@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/6] fs/ext2: always pass the label option
Date: Mon,  3 Jul 2017 17:51:49 +0200	[thread overview]
Message-ID: <20170703155154.24104-2-s.martin49@gmail.com> (raw)
In-Reply-To: <20170703155154.24104-1-s.martin49@gmail.com>

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

... since passing an empty string is equivalent to not setting a label.

And fix the syntax highlighting in some editors...

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Samuel Martin <s.martin49@gmail.com>

---
changes v1->v2:
- rebase
---
 fs/ext2/ext2.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk
index 9d3e8fd666..277e696290 100644
--- a/fs/ext2/ext2.mk
+++ b/fs/ext2/ext2.mk
@@ -20,9 +20,9 @@ endif
 # qstrip results in stripping consecutive spaces into a single one. So the
 # variable is not qstrip-ed to preserve the integrity of the string value.
 EXT2_LABEL := $(subst ",,$(BR2_TARGET_ROOTFS_EXT2_LABEL))
-ifneq ($(EXT2_LABEL),)
+#" Syntax highlighting... :-/ )
+
 EXT2_OPTS += -l "$(EXT2_LABEL)"
-endif
 
 ROOTFS_EXT2_DEPENDENCIES = host-mke2img
 
-- 
2.13.2

  reply	other threads:[~2017-07-03 15:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 15:51 [Buildroot] [PATCH v2 0/6] fs/ext2: cleanup and improvement Samuel Martin
2017-07-03 15:51 ` Samuel Martin [this message]
2017-07-03 15:51 ` [Buildroot] [PATCH v2 2/6] fs/ext2: allow reserving zero block for root Samuel Martin
2017-07-03 15:51 ` [Buildroot] [PATCH v2 3/6] fs/ext2: use mkfs to generate rootfs image Samuel Martin
2017-07-03 16:38   ` Yann E. MORIN
2017-07-03 15:51 ` [Buildroot] [PATCH v2 4/6] fs/ext2: Add BR2_TARGET_ROOTFS_EXT2_FEATURES option Samuel Martin
2017-07-03 15:51 ` [Buildroot] [PATCH v2 5/6] fs/ext2: simplify code Samuel Martin
2017-07-03 15:51 ` [Buildroot] [PATCH v2 6/6] package/mke2img: remove package Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170703155154.24104-2-s.martin49@gmail.com \
    --to=s.martin49@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox