Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libpwquality: select cracklib
Date: Mon,  3 Jul 2017 18:58:27 +0200	[thread overview]
Message-ID: <20170703165827.19052-1-peter@korsgaard.com> (raw)

libpwquality adds cracklib to its _DEPENDENCIES, but forgot to select it in
Config.in, leading to build failures if cracklib isn't explicitly enabled:

Makefile:536: *** cracklib is in the dependency chain of libpwquality that
has added it to its _DEPENDENCIES variable without selecting it or depending
on it from Config.in.  Stop.

No autobuilder references as this error happens before build-time.log is
written, causing the autobuilder to ignore the build result.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/libpwquality/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libpwquality/Config.in b/package/libpwquality/Config.in
index 4e855254a6..23e15157d1 100644
--- a/package/libpwquality/Config.in
+++ b/package/libpwquality/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBPWQUALITY
 	bool "libpwquality"
+	select BR2_PACKAGE_CRACKLIB
 	help
 	  This is a library for password quality checks and generation
 	  of random passwords that pass the checks.  This library uses
-- 
2.11.0

             reply	other threads:[~2017-07-03 16:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 16:58 Peter Korsgaard [this message]
2017-07-03 19:21 ` [Buildroot] [PATCH] libpwquality: select cracklib Arnout Vandecappelle
2017-07-03 20:01 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170703165827.19052-1-peter@korsgaard.com \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox