Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2 v2] system: use Etc/UTC as default timezone
Date: Tue, 4 Jul 2017 09:01:52 +0200	[thread overview]
Message-ID: <20170704090152.388e8128@windsurf> (raw)
In-Reply-To: <4928890759713fe0a785e193fa843dcff9805ed6.1499151384.git.yann.morin.1998@free.fr>

Hello,

On Tue,  4 Jul 2017 08:56:39 +0200, Yann E. MORIN wrote:
> Even though no timezone implicitly means UTC, systemd is not all that
> happy when it does not have a timezone set. This is all fine on a RW
> filesystem because systemd will create a symlink on its own (to
> Etc/UTC), but not so much on a RO filesystem, causing all kind of
> issues at boot time (up to the point that the system is unusable).
> 
> We fix that by requiring that the timezone is actually set. The check is
> done by verifying that the timezone file is an actual file; if not set,
> the test would find a directory and would thus fail.
> 
> Update the help entry accordingly.
> 
> Also fix indentation in tzdata.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Richard Braun <rbraun@sceen.net>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Martin Bark <martin@barkynet.com>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> 
> ---
> Changes v1 -> v2:
>   - don't accept an empty value as meaning the default; enforce that
>     (Arnout)
>   - comit log mentions indentation cleanups  (Arnout)

As discussed IRL, I have changed the commit title. Indeed, Etc/UTC is
already the default timezone. What this patch does is prevent the user
from selecting an empty value for the timezone.

Applied with the commit title fixed. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2017-07-04  7:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04  6:56 [Buildroot] [PATCH 0/2 v2] system: default to using Etc/UTC as a timezone Yann E. MORIN
2017-07-04  6:56 ` [Buildroot] [PATCH 1/2 v2] package/tz: fix variable name Yann E. MORIN
2017-07-04  7:01   ` Thomas Petazzoni
2017-07-04  6:56 ` [Buildroot] [PATCH 2/2 v2] system: use Etc/UTC as default timezone Yann E. MORIN
2017-07-04  7:01   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170704090152.388e8128@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox