Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/helpers.mk: fix creation of DESTDIR in copy_toolchain_lib_root
Date: Wed, 5 Jul 2017 18:11:44 +0200	[thread overview]
Message-ID: <20170705181144.7d30042f@windsurf> (raw)
In-Reply-To: <20170705145418.25101-1-arnout@mind.be>

Hello,

On Wed, 5 Jul 2017 16:54:18 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> In commit b3cc7e65ee, the definition of the DESTDIR variable was moved
> down into the loop that follows symlinks in the libraries that are
> copied to target. However, the corresponding mkdir was not moved down,
> so that no directories are ever created.
> 
> In practice, this mkdir is normally redundant since the directories
> should already have been created as part of creating STAGING_DIR.
> Still, the current situation is clearly wrong, so fix it by moving the
> mkdir down to after the assignment to DESTDIR.
> 
> While we're at it, also remove a redundant empty line. It's a leftover
> from when a lot of variables were declared above.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  toolchain/helpers.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2017-07-05 16:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 14:54 [Buildroot] [PATCH] toolchain/helpers.mk: fix creation of DESTDIR in copy_toolchain_lib_root Arnout Vandecappelle
2017-07-05 16:11 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170705181144.7d30042f@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox