Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] manual: patches are not applied for SITE_METHOD = local
Date: Sun, 9 Jul 2017 17:27:16 +0200	[thread overview]
Message-ID: <20170709172716.1d521e19@windsurf> (raw)
In-Reply-To: <20170708201507.20746-1-arnout@mind.be>

Hello,

On Sat, 8 Jul 2017 22:15:07 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> We had several remarks on the mailing list of users that were surprised
> that patches were not applied for packages whose SITE_METHOD is local.
> So document this.
> 
> Note that for OVERRIDE_SRCDIR itself it is already documented:
> 
>   When Buildroot finds that for a given package, an
>   <pkg>_OVERRIDE_SRCDIR has been defined, it will no longer attempt to
>   download, extract and patch the package. Instead, it will directly use
>   the source code available in in the specified directory.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Applied, thanks!

> diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
> index 12cf1605d6..63ea51bf89 100644
> --- a/docs/manual/adding-packages-generic.txt
> +++ b/docs/manual/adding-packages-generic.txt
> @@ -315,7 +315,10 @@ information is (assuming the package name is +libfoo+) :
>    ** +local+ for a local source code directory. One should use this
>       when +LIBFOO_SITE+ specifies a local directory path containing
>       the package source code. Buildroot copies the contents of the
> -     source directory into the package's build directory.
> +     source directory into the package's build directory. Note that
> +     for +local+ packages, no patches are applied. If you need to
> +     still patch the source code, use +LIBFOO_POST_RSYNC_HOOKS+, see
> +     xref:hooks-rsync[].

The reason why "local" packages don't see their patches applied is
because we assume that if the source code is available locally, you'd
better have the patches applied to it directly. But OK, we can still
point people to the rsynch hooks if they really think they need some
patching.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-07-09 15:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-08 20:15 [Buildroot] [PATCH] manual: patches are not applied for SITE_METHOD = local Arnout Vandecappelle
2017-07-09 15:27 ` Thomas Petazzoni [this message]
2017-07-19 13:52 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170709172716.1d521e19@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox