From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Mon, 10 Jul 2017 22:19:16 +0200 Subject: [Buildroot] [PATCH 2/4 v3] package/kvm-unit-tests: introduce _ARCH_SUPPORTS In-Reply-To: References: <996d1d52c27da1a7725ed425ac895c3a7b5b7301.1499592591.git.yann.morin.1998@free.fr> <20170710180949.764a0fdb@windsurf.lan> <20170710162056.GB3014@scaer> <20170710201005.GA2953@scaer> Message-ID: <20170710201916.GB2953@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, On 2017-07-10 22:12 +0200, Arnout Vandecappelle spake thusly: > On 10-07-17 22:10, Yann E. MORIN wrote: > > On 2017-07-10 21:56 +0200, Arnout Vandecappelle spake thusly: > >> On 10-07-17 18:20, Yann E. MORIN wrote: > >>> On 2017-07-10 18:09 +0200, Thomas Petazzoni spake thusly: > >>>> On Sun, 9 Jul 2017 11:29:59 +0200, Yann E. MORIN wrote: > >>>>> +comment "kvm-unit-tests needs a toolchain w/ gcc >= 4.5" > >>>>> + depends on BR2_i386 > >>>>> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 > >>>> What about the x86_64 dependency on a host compiler >= 4.5 ? > >>> In the manual, it is said that one should not add a comment about a > >>> dependency on the host toolchain... > >> > >> I *think* Thomas didn't mean to say "host compiler". I think he meant: > >> > >> Shouldn't this be: > >> depends on BR2_i386 || BR2_x86_64 > >> depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 > > > > No, because for x86_64 we are using the host compiler. See the .mk file: > > > > # For all architectures but x86-64, we use the target > > # compiler. However, for x86-64, we use the host compiler, as > > # kvm-unit-tests builds 32 bit code, which Buildroot toolchains for > > # x86-64 cannot do. > > ifneq ($(BR2_x86_64),y) > > KVM_UNIT_TESTS_CONF_OPTS += --cross-prefix="$(TARGET_CROSS)" > > endif > > > > So for x86_64 there is no dependency to add on the target compiler at > > all. > > D'oh, I missed that subtlety, thanks for the explanation. Yep, no problem. I got bitten by it as well, that's why I "fixed" it (and I should have improved the commit log a bit more, it seems ;-) ). Thanks for the reviews! :-) Regards, Yann E. MORIN. > Regards, > Arnout > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'