From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5: bump latest version to 5.9.1
Date: Thu, 13 Jul 2017 17:32:20 +0200 [thread overview]
Message-ID: <20170713153220.GA3002@scaer> (raw)
In-Reply-To: <20170713095003.057fb2bc@windsurf.orange-hotspot.com>
Thomas, Joshua, All,
On 2017-07-13 09:50 +0200, Thomas Petazzoni spake thusly:
> On Wed, 12 Jul 2017 17:51:38 -0700, Joshua Henderson wrote:
>
> > I tested adding hashes for all license files for 5.9.1. It turns out, this breaks the 5.6.2
> > legal-info because there are files in common between the two versions, but with different hashes.
> >
> > $ make legal-info
> >
> > ...
> >
> > >>> qt5base 5.6.2 Collecting legal info
> > LICENSE.GPLv3: OK (sha256: 245248009fd0af1725d183248380e476c1283383909358a13686606352bf2a17)
> > ERROR: No hash found for LICENSE.LGPLv21
> > ERROR: No hash found for LGPL_EXCEPTION.txt
> > LICENSE.LGPLv3: OK (sha256: 68afaf3392f8c04218fbf29db43cc0b18bf651c1db086556aa584046de9f3e35)
> > LICENSE.FDL: OK (sha256: ed8742a95cb9db653a09b050e27ccff5e67ba69c14aa2c3137f2a4e1892f6c0d)
> > ERROR: header.BSD has wrong sha256 hash:
> > ERROR: expected: 8fdefa0b45d9f791f687da6c2c4c83c1b701aaee2c08008f55d522af214b88f0
> > ERROR: got : 1d05f2662f0be7544c4cc238d0957d1ed5d0edc45210e9108f905df354241a0e
> > ERROR: Incomplete download, or man-in-the-middle (MITM) attack
> > package/qt5/qt5base/qt5base.mk:315: recipe for target 'qt5base-legal-info' failed
> > make[1]: *** [qt5base-legal-info] Error 1
> > Makefile:79: recipe for target '_all' failed
> > make: *** [_all] Error 2
> >
> > In the case you have different license file contents, but with the same name, between different
> > versions of a package, how should this be handled?
>
> This is a *very* good question,
Indeed, this is a *very* good question.
> and I don't think our current support
> for license file hashes handles this situation properly.
Indeed our current infra does not support this... Dang... :-(
I'll see what I can do with this...
Until then, don't add hashes for Qt license files... :-/
A first idea would be to look for a hash file in the ${VERSION}
subdirectory, where we are currently only looking for patches. This
should be safe, as we currently only use *.patch from there.
But I'm not too happy with this... :-/
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-07-13 15:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 18:00 [Buildroot] [PATCH] package/qt5: bump latest version to 5.9.1 Joshua Henderson
2017-07-12 0:45 ` Arnout Vandecappelle
2017-07-12 1:41 ` Brent Sink
2017-07-12 7:23 ` Arnout Vandecappelle
2017-07-12 15:55 ` Joshua Henderson
2017-07-12 23:04 ` Joshua Henderson
2017-07-13 0:51 ` Joshua Henderson
2017-07-13 7:50 ` Thomas Petazzoni
2017-07-13 15:32 ` Yann E. MORIN [this message]
2017-07-13 22:46 ` Arnout Vandecappelle
2017-07-14 8:35 ` Thomas Petazzoni
2017-07-14 13:12 ` Peter Korsgaard
2017-07-14 13:36 ` Thomas Petazzoni
2017-07-14 13:49 ` Peter Korsgaard
2017-07-16 17:25 ` Yann E. MORIN
2017-07-13 9:11 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713153220.GA3002@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox