From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available
Date: Sat, 15 Jul 2017 21:44:47 +0200 [thread overview]
Message-ID: <20170715214447.76763605@windsurf> (raw)
In-Reply-To: <1500140309-26534-1-git-send-email-martin@barkynet.com>
Hello,
On Sat, 15 Jul 2017 18:38:27 +0100, Martin Bark wrote:
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 43c5ff3..a469153 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -34,6 +34,11 @@ else
> NODEJS_CONF_OPTS += --with-intl=none
> endif
>
> +ifeq ($(BR2_PACKAGE_C_ARES),y)
> +NODEJS_DEPENDENCIES += c-ares
> +NODEJS_CONF_OPTS += --shared-cares
> +endif
So what happens if BR2_PACKAGE_C_ARES is disabled? It is not
needed/used by nodejs, or some internal/built-in version is used?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-15 19:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 17:38 [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares if available Martin Bark
2017-07-15 17:38 ` [Buildroot] [PATCH 2/3] package/nodejs: use shared libhttpparser " Martin Bark
2017-07-15 17:38 ` [Buildroot] [PATCH 3/3] package/nodejs: use shared libuv " Martin Bark
2017-07-15 19:44 ` Thomas Petazzoni [this message]
2017-07-15 23:12 ` [Buildroot] [PATCH 1/3] package/nodejs: use shared c-ares " Martin Bark
2017-07-16 7:16 ` Thomas Petazzoni
2017-07-17 8:43 ` Martin Bark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170715214447.76763605@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox